Bug 52282

Summary: [softpipe] piglit arb_shader_texture_lod-texgrad regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: galibert
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: arb_shader_texture_lod-texgrad.png

Description Vinson Lee 2012-07-20 00:36:41 UTC 
Created attachment 64410 [details]
arb_shader_texture_lod-texgrad.png

mesa: a8c092266e9885f3370bbeae15bd80ebf035d05d (master)

Run piglit arb_shader_texture_lod-texgrad on softpipe.

$ ./bin/arb_shader_texture_lod-texgrad -auto
Mesa warning: failed to remap index 173
Left: texture2D, Right: texture2DGradARB
Probe at (4,3)
  Left: 0.000000 1.000000 0.000000 1.000000
  Right: 0.000000 0.976471 0.000000 1.000000
PIGLIT: {'result': 'fail' }


229a1a7e4da1a9c60b35b79f2a63e0bab451a76e is the first bad commit
commit 229a1a7e4da1a9c60b35b79f2a63e0bab451a76e
Author: Olivier Galibert <galibert@pobox.com>
Date:   Tue Jun 19 21:01:37 2012 +0200

    softpipe: Take all lods into account when texture sampling.

    This patch churns a lot because it needs to change 4-wide filters into
    single pixel filters, since each fragment may use a different filter.

    The only case not entirely supported is the anisotropic filtering.
    Not sure what we want to do there, since a full quad is required by
    that filter.

    Signed-off-by: Olivier Galibert <galibert@pobox.com>
    Reviewed-by: Brian Paul <brianp@vmware.com>

:040000 040000 b097530109abfbb406df16689a45154ba31e72f1 37331d8c61f88d8908f3bd5056fd4a08888a0e3d M      src
bisect run success
Comment 1 Olivier Galibert 2012-07-20 07:15:45 UTC 
galibert@tata:~/X/piglit #16 >./bin/arb_shader_texture_lod-texgrad -auto
Left: texture2D, Right: texture2DGradARB
PIGLIT: {'result': 'pass' }

I'm not getting that, and I'm obviously not getting the moire effect either.  I'll try to reproduce on other systems.
Comment 2 Brian Paul 2012-07-25 14:03:29 UTC 
This was also fixed by commit fa76d04aeaf249956072c023661b1e2cda103584.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.