Bug 5230

Summary: invalid spaces in Xwin section of xserver configure.ac
Product: xorg Reporter: Egmont Koblinger <egmont>
Component: Build/ModularAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high    
Version: 6.99.99.902 (7.0 RC2)   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 1690    

Description Egmont Koblinger 2005-12-03 07:43:41 UTC
Quoting from xorg-server/configure.ac:

if test "x$XF86VIDMODE" = xyes; then
    AC_MSG_NOTICE([Disabling XF86VidMode extension])
    XF86VIDMODE = no
fi

[ and then two more similar ones right after this one ]

Notice the spaces around the = sign when a value is given to a shell variable,
this is not valid in shell script. It leads to stupid messages such as
./configure: line 17692: XF86VIDMODE: command not found
and the extensions are actually not disabled, only the notice is printed.

-=-=-=-=-=-=-

I don't know if it is related or not, but later I get a linker error message
when compiling with "--enable-xwin":
[...]
i586-uhu-linux-gcc [tons of arguments]
../../dix/.libs/libdix.a(dispatch.o): In function `Dispatch':
dispatch.c:(.text+0x6f3): undefined reference to `ddxBeforeReset'
collect2: ld returned 1 exit status
make[4]: *** [Xorg] Error 1
make[4]: Leaving directory `...../hw/xfree86'
make[3]: *** [all-recursive] Error 1
[...]

Maybe I just simply shouldn't try to enable Xwin on Linux+gcc since it really
doesn't make much sense :-)
Comment 1 Adam Jackson 2005-12-07 03:19:23 UTC
fixed the whitespace.  and yeah, Xwin won't link on linux.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.