Bug 52346

Summary:	libxcb version not specified (correctly) in dependency check
Product:	Mesa	Reporter:	Darxus <darxus>
Component:	Other	Assignee:	mesa-dev
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	git
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Darxus 2012-07-21 16:56:57 UTC

With libxcb1 v1.7, mesa fails to build with:

make[3]: Entering directory `/home/darxus/source.test.master/mesa/src/glx'
create_context.c:103:7: error: implicit declaration of function 'xcb_glx_create_context_attribs_arb_checked' [-Werror=implicit-function-declaration]

With xcb rebuilt from git, it builds.  There are rumours that it depends on xcb v1.8.1.

12:21PM < tilman> Darxus: http://e8903aeff8f0df94.paste.se/ does that patch fix the problem?
12:23PM < mattst88> weird. we have PKG_CHECK_MODULES([XCB],[x11-xcb xcb-glx >= 1.8.1]) a few lines below.
12:23PM < mattst88> oh, that's in the else case
12:26PM < mattst88> so, that whole if/else block just allows people to compile Mesa without having the X pkgconfig files?
12:27PM < mattst88> if I'm reading that right, that seems really silly.

The patch tillman mentioned is, in configure.ac:

-        dri_modules="x11 xext xdamage xfixes x11-xcb xcb-glx"
+        dri_modules="x11 xext xdamage xfixes x11-xcb xcb-glx >= 1.8.1"

This is a new build failure that showed up in the last week on Ubuntu Oneric.

Comment 1 Tom Stellard 2012-07-23 13:18:19 UTC

I sent a patch to fix this to the mailing list a few days ago.  http://comments.gmane.org/gmane.comp.video.mesa3d.devel/42535

I'm not really sure if this is correct. I was hoping to get some reviews, but I can push it if it fixes the problem for you.

Comment 2 Kenneth Graunke 2012-08-12 22:44:20 UTC

I've pushed Tom's patch, which should fix this issue.

commit e98ace934e1ea875f352fcef823ca46a416ca751
Author: Tom Stellard <tstellar@gmail.com>
Date:   Fri Jul 13 13:46:23 2012 +0000

    configure: Check xcb version when X11 pkgconfig exists
    
    Commit 6882381a2efbdf06b7002d11468c94b9964c2bc8 added a dependency on a
    newer version of xcb, but the version check wasn't added in all the
    necessary places.
    
    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>

Matt raises a good point, however...I think at this point, X11 without pkg-config is so ancient that we should really just scrap all of that.  But that's a separate cleanup.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.