Bug 52369

Summary: [softpipe] piglit mipmap-setup regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: galibert
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2012-07-22 19:59:55 UTC
mesa: f96405f254819238ef6bce8e7341fcc7d00eaf85 (master)

Run piglit mipmap-setup on softpipe.

$ ./bin/mipmap-setup -auto
Mesa warning: failed to remap index 173
Probe at (100,100)
  Expected: 0.392157 0.392157 0.392157
  Observed: 0.470588 0.470588 0.470588
  At mipmap level 0, order = Normal
Probe at (100,100)
  Expected: 0.470588 0.470588 0.470588
  Observed: 0.549020 0.549020 0.549020
  At mipmap level 1, order = Normal
Probe at (100,100)
  Expected: 0.549020 0.549020 0.549020
  Observed: 0.627451 0.627451 0.627451
  At mipmap level 2, order = Normal
Probe at (100,100)
  Expected: 0.627451 0.627451 0.627451
  Observed: 0.705882 0.705882 0.705882
  At mipmap level 3, order = Normal
Probe at (100,100)
  Expected: 0.705882 0.705882 0.705882
  Observed: 0.784314 0.784314 0.784314
  At mipmap level 4, order = Normal
Probe at (100,100)
  Expected: 0.784314 0.784314 0.784314
  Observed: 0.862745 0.862745 0.862745
  At mipmap level 5, order = Normal
Probe at (100,100)
  Expected: 0.862745 0.862745 0.862745
  Observed: 0.941176 0.941176 0.941176
  At mipmap level 6, order = Normal
PIGLIT: {'result': 'fail' }


229a1a7e4da1a9c60b35b79f2a63e0bab451a76e is the first bad commit
commit 229a1a7e4da1a9c60b35b79f2a63e0bab451a76e
Author: Olivier Galibert <galibert@pobox.com>
Date:   Tue Jun 19 21:01:37 2012 +0200

    softpipe: Take all lods into account when texture sampling.
    
    This patch churns a lot because it needs to change 4-wide filters into
    single pixel filters, since each fragment may use a different filter.
    
    The only case not entirely supported is the anisotropic filtering.
    Not sure what we want to do there, since a full quad is required by
    that filter.
    
    Signed-off-by: Olivier Galibert <galibert@pobox.com>
    Reviewed-by: Brian Paul <brianp@vmware.com>

:040000 040000 b097530109abfbb406df16689a45154ba31e72f1 37331d8c61f88d8908f3bd5056fd4a08888a0e3d M	src
bisect run success
Comment 1 Brian Paul 2012-07-25 13:48:12 UTC
Fixed with commit fa76d04aeaf249956072c023661b1e2cda103584

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.