Bug 52517

Summary: [Regression] Fullscreen can't be executed in clickdot, dnd, eventdemo, resizor and flower.
Product: Wayland Reporter: ZhaoShengyan <shengyanx.zhao>
Component: westonAssignee: Wayland bug list <wayland-bugs>
Status: VERIFIED NOTABUG QA Contact:
Severity: critical    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description ZhaoShengyan 2012-07-26 01:26:32 UTC 
System Environment:
--------------------------
Arch:    i386
Libdrm:  (master)libdrm-2.4.37-20-gebd7904877d08525beb5039e4ea2f5b6c0a7c23f
Wayland: (master)f5ccd7a9e670e097ff9b5faae8a26b3af4bb7b60
Mesa:    (master)497bf5dd2b36c7d0c8ae23d2bf039c91b97140fc
Xserver: (master)xorg-server-1.12.99.902
Xf86_video_intel: (master) 2.20.1-6-gc1785aaca2c9347114d28f114ee59ef8206d829b
Cairo:   (master)d00539ca13fbd36dea07b386211ad49ef744d5ee
Cairo_gl:(master) d00539ca13fbd36dea07b386211ad49ef744d5ee
Xkbcommon:(master) 9bd55b55f8044ab105097af3b59db81f01db6c1a
Weston:   (master) e302b3ef77894cb9fd4113c873a5502efc9a8dd6
Kernel_unstable: (drm-intel-next-queued)
b565cf6cf83ec835e160d10bece043703cc0a9f1

Bug detailed description:
-----------------------------
Run case clickdot, and then execute fullscreen, nothing happened. Similar situations appeared at dnd, eventdemo, resizor, and flower, while fullscreen can be triggered normally at image and weston-terminal. 
The issue can be reproduced both under drm and X mode.


Reproduce steps:
----------------------------
1. Start weston
2. ./clickdot
3. Rightclick and choose fullscreen.
Comment 1 ZhaoShengyan 2012-07-26 07:31:26 UTC 
The first bad commit at Weston:

commit 67ace20f8ebc2088d560874c49eb79ca122b68da
Author: Kristian Høgsberg <krh@bitplanet.net>
Date:   Mon Jul 23 21:56:31 2012 -0400

    window.c: Add fullscreen handler to keep fullscreen state consistent
Comment 2 Scott Moreau 2012-08-01 03:36:42 UTC 
Clients must opt-in to use toytoolkit fullscreen toggle by calling window_set_fullscreen_handler() accordingly. In the patch http://cgit.freedesktop.org/wayland/weston/commit/?id=67ace20f8ebc2088d560874c49eb79ca122b68da you can see what a toytoolkit client must do to allow fullscreen toggling by looking at the changes made to weston-terminal. Ultimately, this is not a bug.
Comment 3 ZhaoShengyan 2012-08-27 02:32:22 UTC 
Marked as Verified and notabug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.