Bug 52540

Summary: : Ligatures hyphenation bug using graphite font (Linux Libertine G): "ligc" is ignored
Product: LibreOffice Reporter: dan980
Component: WriterAssignee: martin_hosken
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: axel.niedenhoff, glanthor, nemeth
Version: 3.5.5.3 releaseKeywords: regression
Hardware: Other   
OS: All   
Whiteboard: BSA target:4.2.0 target:4.0.4 target:4.1.0.0.beta1
i915 platform: i915 features:
Attachments: test document
English test file
Not extra, but missing ligature.

Description dan980 2012-07-26 13:11:45 UTC
Created attachment 64732 [details]
test document

Problem description: 
Linux Libertine G by default handles the standards ligatures, like ff, ffi, ffl, tt.
On hyphenated words, the ligature is not omitted.
Using the test text "Lorem ipsum differenza"
I get this beaviour:

Lorem ipsum diff-
ferenza

while it should be:

Lorem ipsum dif-
ferenza

Linux Libertine offers a variant, "Linux Libertine G:ligc=1" which should correct ligatures on hyphenated words. But apparently it is ignored on the latest version of Libreoffice.

Note: I'm using the Italian hyphenation.

Steps to reproduce:
1. Enable hyphenation on the current paragraph
2. Set "Linux Libertine G:ligc=1" as the current font
3. Paste same test text that gets hyphenated on a standard ligature 

Current behavior:
A ligature is added before the hyphenation line.

Expected behavior:
No ligature should be added.

Platform (if different from the browser): 
              
Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Libreoffice 3.5.5.3
Linux Libertine G version 2012-01-16
Comment 1 László Németh 2012-08-08 13:03:29 UTC
Confirmed with LibreOffice 3.6.
Comment 2 László Németh 2012-08-13 13:51:27 UTC
*** Bug 52544 has been marked as a duplicate of this bug. ***
Comment 3 László Németh 2013-04-11 00:51:05 UTC
Created attachment 77793 [details]
English test file

Hyphenation of “proofing” in LibreOffice is proofi- ing.
Comment 4 László Németh 2013-04-12 09:22:02 UTC
Workaround: put soft hyphen at the bad break point.

[Note (another, but related bug): there is no kerning before the hyphen and Graphite ligature replacement before extra characters of a special hyphenation, eg. Hungarian cursive gy ligature in roggyan -> rogy=gyan, second test file attached.]
Comment 5 László Németh 2013-04-12 09:23:41 UTC
Created attachment 77854 [details]
Not extra, but missing ligature.

Automatic hyphen and extra characters before the special hyphenation don't handled by Graphite kerning and ligature replacement.
Comment 6 Commit Notification 2013-05-22 07:19:06 UTC
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=56ae7a8c50c4040a7634986a055161b3aeb5819a

fdo#52540 fix hyphenation of Graphite ligatures



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2013-05-22 08:06:24 UTC
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to "libreoffice-4-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7d1e6cb0564a1eb886fd8f95adbcc7d8b9aa028f&h=libreoffice-4-0

fdo#52540 fix hyphenation of Graphite ligatures


It will be available in LibreOffice 4.0.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2013-05-22 08:14:13 UTC
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to "libreoffice-4-1":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=4233b2d5c13887f4b8e68fb59a54aa2b09c9a66b&h=libreoffice-4-1

fdo#52540 fix hyphenation of Graphite ligatures


It will be available in LibreOffice 4.1.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2013-09-06 14:02:16 UTC
Laszlo Nemeth committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=58e1112a6a974b96bb8595e3ee9d08e915d4fd14

fdo#52540 fix Graphite hyphenation (ligat. + combining diac.)



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.