Bug 5258

Summary: Layout change in PictureRec breaks binary compatibility
Product: xorg Reporter: Aaron Plattner <aplattner>
Component: Server/GeneralAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: high    
Version: unspecified   
Hardware: x86 (IA32)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 1690    
Attachments:
Description Flags
Move new functionality to the end of the bitfield ajax: 6.9/7.0+

Description Aaron Plattner 2005-12-07 16:47:52 UTC 
On Jul. 1, 2005 the PictureRec structure was changed such that the
graphicsExposures, subWindowMode, polyEdge, polyMode, freeCompClip,
freeCompClip, clientClipType, and componentAlpha flags moved around in the
bitfield in the middle of this structure.  This change was part of gradient
support for RENDER.
Comment 1 Aaron Plattner 2005-12-07 16:52:34 UTC 
Created attachment 4016 [details] [review]
Move new functionality to the end of the bitfield

This patch restores the original size of the repeat flag and adds a new 2-bit
repeatType field.  It also updates the places that use the new repeat types to
use the repeatType field.  This restores ABI compatibility with xorg 6.8.2.
Comment 2 Adam Jackson 2005-12-08 01:41:34 UTC 
Comment on attachment 4016 [details] [review]
Move new functionality to the end of the bitfield

nominating for 7, but i'd like some discussion on this.  i don't think this
affects exa (i'll rebuild it with the fix to check), so i'm a bit unclear on
why the nvidia driver would be affected.
Comment 3 Eric Anholt 2005-12-08 07:54:51 UTC 
The diff looks sane to me from a brief look.  Note that currently drivers that
accelerate Render in EXA are behaving brokenly in the presence of the new
repeat-type (rather than the boolean repeat-or-not).  XAA's limited Render accel
should be clean iirc.
Comment 4 Adam Jackson 2005-12-10 03:48:49 UTC 
Comment on attachment 4016 [details] [review]
Move new functionality to the end of the bitfield

approved, i'll check this in.
Comment 5 Adam Jackson 2005-12-10 05:31:26 UTC 
applied, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.