Bug 53166

Summary:	flawed representation of contact caps (can't deal with clients going away?)
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	salut	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Simon McVittie 2012-08-06 15:26:37 UTC

Gabble represents contact caps like this:

* Connection maintains a table { client name => caps set }
* When a new client appears, every channel manager is asked to
  "represent" that client, building up a list of caps that is the
  union of each channel manager's representation
* The caps emitted onto the network are the union of all clients'
  capabilities
* When a client goes away, it is removed from the table and the
  union is re-calculated

Salut, by contrast, does this:

* When a new client appears, every channel manager is asked to
  "represent" that client, storing the representation internally;
  it then emits the union of every client it cares about, including
  ones it isn't currently trying to represent

I'm not sure whether this deals correctly with clients going away.

It certainly requires more subtlety from channel managers than they ought to have (see Ytstenut's plugin-base/caps-manager.c, and a Yts bug I'm about to file).

Fixing this will break out-of-tree channel managers. The one in ytstenut-plugins is the only known example.

Comment 1 GitLab Migration User 2019-12-03 20:16:09 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-salut/issues/40.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.