Bug 53243

Summary: Newer Samsung Series 9 model are not matched by udev keymap rules
Product: systemd Reporter: Alessandro Crismani <alessandro.crismani>
Component: generalAssignee: systemd-bugs
Status: RESOLVED FIXED QA Contact: systemd-bugs
Severity: minor    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch for including newer Samsung Series 9 model into udev rules

Description Alessandro Crismani 2012-08-08 13:05:50 UTC
Created attachment 65281 [details] [review]
Patch for including newer Samsung Series 9 model into udev rules

Udev has a rule for matching the Samsung Series 9 NP90X3A laptop and set particular keycodes for a handful of unrecognised keys.

Samsung introduced updated Series 9 models, codenamed NP900X3B, NP900X3C, NP900X4B, NP900X4C that are currently not matched by udev rules. Hence, keyboard brightness keys, the silent mode key and the easy setting key are not functioning.

Attached to this report there is a patch that improves the situation by including the ID of newer products in udev rules, so that they are recognised.

This is my first patch, so please be patient if I made horrible mistakes.

Cheers,
Alessandro
Comment 1 Patrick Nicolas 2012-09-26 13:38:10 UTC
900X1B model should also be included, here is the DMI line from dmesg output.

DMI: SAMSUNG ELECTRONICS CO., LTD. 900X1B/900X1B, BIOS 01FQ 06/09/2011
Comment 2 Martin Pitt 2012-11-28 20:28:30 UTC
Indeed, this very much looks like a pattern, so if we get more entries in the "or"ed list, we should probably generalize it even further.

I applied your patch together with the necessary adjustments to Makefile.am.

Thank you!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.