Bug 53275

Summary: [Bisected IVB SNB regression]Piglit glean/logicOp fails
Product: Mesa Reporter: lu hua <huax.lu>
Component: Drivers/DRI/i965Assignee: Chad Versace <chadversary>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: high CC: idr, xunx.fang
Version: git   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: output

Description lu hua 2012-08-09 01:24:59 UTC
Created attachment 65317 [details]
output

System Environment:
--------------------------
Arch:             X86_64
Platform:         Ivybridge
Libdrm:	(master)libdrm-2.4.37-24-g9f823ca236058d7eb37d54a077170fff2d691b99
Mesa:(master)7528e2104fdda88a9eca5d84d979a21f5c517dc9
Xserver:(master)xorg-server-1.12.99.904
Xf86_video_intel:(master)2.20.3-11-g1a0590d133ea6991e0939d1f170f9c10df6856a0
Libva:	(staging)f12f80371fb534e6bbf248586b3c17c298a31f4e 
Libva_intel_driver:(staging)82fa52510a37ab645daaa3bb7091ff5096a20d0b
Kernel:	(drm-intel-next-queued) ab3951eb74e7c33a2f5b7b64d72e82f1eea61571

Bug detailed description:
------------------------- 
It fails on ivybridge and sandybridge with mesa master branch.It doesn't happen on mesa 8.0 branch.
Following cases also fail and have same bisect commit:
glean_orthoPosHLines
glean_orthoPosHLines
glean_orthoPosRandRects
glean_orthoPosRandTris
glean_orthoPosTinyQuads
glean_orthoPosVLines
glean_pointSprite

Bisect shows:e943e5c291c5f4c017f9f5a483f1940313333fc3 is the first bad commit.

commit e943e5c291c5f4c017f9f5a483f1940313333fc3
Author:     Chad Versace <chad.versace@linux.intel.com>
AuthorDate: Thu Aug 2 17:13:17 2012 -0700
Commit:     Chad Versace <chad.versace@linux.intel.com>
CommitDate: Tue Aug 7 09:30:34 2012 -0700

    intel: Advertise multisample DRI2 configs on gen >= 6

    This turns on window system MSAA.

    This patch changes the id of many GLX visuals and configs, but that
    couldn't be prevented. I attempted to preserve the id's of extant configs
    by appending the multisample configs to the end of the extant ones. But
    somewhere, perhaps in the X server, the configs are reordered with
    multisample configs interspersed among the singlesample ones.

Reproduce steps:
----------------
1. start X
2. ./bin/glean -r /tmp/logicOp -o -v -v -v -t +logicOp
Comment 1 Chad Versace 2012-08-09 23:04:18 UTC
The bug is in glean, not Mesa. Patch submitted to piglit list:

Author: Chad Versace <chad.versace@linux.intel.com>
Date:   Thu Aug 9 15:55:49 2012 -0700

    glean: Skip multisample configs
    
    Many tests do not adjust their expectations for mutlisampling and hence
    incorrectly fail.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53275
    Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
Comment 2 Chad Versace 2012-08-10 14:39:59 UTC
Change status to RESOLVED/FIXED.

Patch is committed as b1a2dafd421fc4f03c978e4ebf25f6d9fdad35a9.
Comment 3 lu hua 2012-08-14 01:13:16 UTC
Verified.Fixed on piglit commit b1a2dafd421fc4f03c978e4ebf25f6d9fdad35a9
commit b1a2dafd421fc4f03c978e4ebf25f6d9fdad35a9
Author: Chad Versace <chad.versace@linux.intel.com>
Date:   Thu Aug 9 15:55:49 2012 -0700

    glean: Skip multisample configs

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.