| Summary: | [Bisected i965]Oglc fboarb(advanced.blit.copypix) regressed | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Kenneth Graunke <kenneth> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | idr, jljusten, xunx.fang |
| Version: | 9.0 | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | output | ||
|
Description
lu hua
2012-08-16 06:23:41 UTC
It also happens on ivybridge and sandybridge with mesa master branch. It fails on ironlake, ivybridge and sandybridge with mesa 9.0 branch (commit:c7775e842bec815ede6badc35d). I sent a patch which fixes this issue to the mailing list: http://lists.freedesktop.org/archives/mesa-dev/2012-September/027521.html Fixed on master by: commit 3767b25bd3f77cede452cfbe9b66a51b352d9036 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Sat Sep 15 23:18:36 2012 -0700 meta: Use float for temporary images, not (un)signed normalized. In commit 091eb15b694, Jordan changed get_temp_image_type() to use _mesa_get_format_datatype() instead of returning GL_FLOAT. That has several possible return values: GL_FLOAT, GL_INT, GL_UNSIGNED_INT, GL_SIGNED_NORMALIZED, and GL_UNSIGNED_NORMALIZED. We do want to use GL_INT/GL_UNSIGNED_INT for integer formats. However, we want to continue using GL_FLOAT for the normalized fixed-point types. There isn't any code in pack.c to handle GL_(UN)SIGNED_NORMALIZED. Fixes oglconform's fboarb advanced.blit.copypix, which was regressed by commit 091eb15b694a396f8453093575ccec2db7f14eb8. NOTE: This is a candidate for the 9.0 branch. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53573 Signed-off-by: Kenneth Graunke <kenneth@whitecape.org> Cherry-picking to 9.0 is still pending. Ian cherry-picked this to 9.0. Closing as fixed. Verified.Fixed on master branch by commit:3767b25bd3f77cede452cfbe9b66a51b352d9036 commit 3767b25bd3f77cede452cfbe9b66a51b352d9036 Author: Kenneth Graunke <kenneth@whitecape.org> Date: Sat Sep 15 23:18:36 2012 -0700 meta: Use float for temporary images, not (un)signed normalized. Fixed on 9.0 branch by commit:549129838ca5f80152c83474276b65f89b0f8013 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.