Bug 53664

I can't reproduce that here.  These function prototypes come from src/mesa/main/drawtex.h, which is included at line 29 of es1_conversion.c.  Is this limited to scons builds?  If you can reproduce it with automake, what options do you use?

I can't repro this either.

The only way I could see this occurring is if FEATURE_OES_draw_texture was somehow undefined.  This only happens when FEATURE_ES1 is not defined.  In this case, es1_conversion.c shouldn't even be built.

If this is scons-only, then my speculative SConscript changes are, in fact, broken. :(

Created attachment 65721 [details]
make log

I'm also getting this.

Using:  ./autogen.sh --prefix=$installdir --enable-gles2 --disable-gallium-egl --with-egl-platforms=wayland,x11,drm --enable-gbm --enable-shared-glapi --with-gallium-drivers=r300,r600,swrast,nouveau,svga

Attaching configure and make logs.  Let me know if I can get you anything else.  I'll work on bisecting.

Created attachment 65722 [details]
configure log

First known bad commit:  34472a0d8713c4eb300c9d1de0844c8b78bcf1ab
Last known good commit:  d707e337f5f9a7b6ed465ade1b0b7c06606dde22

And they're sequential... no bisecting for me.

The SCons build passes.

$ scons
[...]
scons: done building targets.


The automake build fails.

$ ./autogen.sh --with-dri-drivers=swrast --with-gallium-drivers=
[...]
        prefix:          /usr/local
        exec_prefix:     ${prefix}
        libdir:          ${exec_prefix}/lib
        includedir:      ${prefix}/include

        OpenGL:          yes (ES1: no ES2: no)
        OpenVG:          no

        OSMesa:          no
        DRI drivers:     swrast
        DRI driver dir:  ${libdir}/dri
        GLX:             DRI-based

        GLU:             yes

        EGL:             yes
        EGL platforms:   x11
        EGL drivers:     builtin:egl_glx builtin:egl_dri2

        llvm:            no

        Gallium:         no

        Shared libs:     yes
        Static libs:     no

        CFLAGS:          -g -O2 -Wall -std=c99 -Werror=implicit-function-declaration -Werror=missing-prototypes -fno-strict-aliasing -fno-builtin-memcmp -fPIC
        CXXFLAGS:        -g -O2 -Wall -fno-strict-aliasing -fno-builtin-memcmp -fPIC
        Macros:          -D_GNU_SOURCE -DPTHREADS -DUSE_X86_64_ASM -DHAVE_POSIX_MEMALIGN -DIN_DRI_DRIVER -DUSE_XCB -DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER -DHAVE_ALIAS -DHAVE_MINCORE -DHAVE_LIBUDEV

        PYTHON2:         python2

        Run 'make' to build Mesa

$ make
[...]
  CC     es1_conversion.lo
../../src/mesa/main/es1_conversion.c: In function '_es_DrawTexxOES':
../../src/mesa/main/es1_conversion.c:130:5: error: implicit declaration of function '_mesa_DrawTexf' [-Werror=implicit-function-declaration]
../../src/mesa/main/es1_conversion.c: In function '_es_DrawTexxvOES':
../../src/mesa/main/es1_conversion.c:147:5: error: implicit declaration of function '_mesa_DrawTexfv' [-Werror=implicit-function-declaration]

Created attachment 65724 [details]
config.log

Looks like es1_conversion.c should use #if instead of #ifdef for the FEATURE_ES1 check.

I submitted a patch to the mailing list.

Thanks.  I repro'd the issue here and your patch fixes it.  Thanks, Tilman!  Pushed as d0ace4e949d0e2f11e6f0fb0fd97ccde58457937