| Summary: | use AS_IF, AS_CASE instead of if/fi and case/esac | ||
|---|---|---|---|
| Product: | Telepathy | Reporter: | Simon McVittie <smcv> |
| Component: | salut | Assignee: | Simon McVittie <smcv> |
| Status: | RESOLVED FIXED | QA Contact: | Telepathy bugs list <telepathy-bugs> |
| Severity: | minor | ||
| Priority: | low | CC: | will |
| Version: | unspecified | Keywords: | patch |
| Hardware: | Other | ||
| OS: | All | ||
| URL: | http://cgit.freedesktop.org/~smcv/telepathy-salut/log/?h=trivia-54119 | ||
| Whiteboard: | review+ | ||
| i915 platform: | i915 features: | ||
|
Description
Simon McVittie
2012-08-27 09:45:08 UTC
Here is a branch with this change and a bunch of other trivia. (Branch updated, now at e1a4558.) (And again, 58aefe4) -if grep -n '^ *GError *\*[[:alpha:]_][[:alnum:]_]* *;' "$@" -then - echo "^^^ The above files contain uninitialized GError*s - they should be" - echo " initialized to NULL" - fail=1 -fi - Ugh, I found http://cgit.freedesktop.org/telepathy/telepathy-glib/commit/?id=05b3d1e1f9d5c63d0d01a9cecc3f04cae3191605 and I don't really agree that this is legit unless you have the GError in a struct I guess? Oh well. This branch looks fine. I skim-read a lot of it, to be honest, but I read the bits that might cause havoc (eg. sealed struct updates) and they seem fine. Fixed in git for 0.9.0. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.