Bug 54140

Summary: [llvmpipe] GL_EXT_texture_compression_s3tc is no longer enabled even when libtxc_dxtn is available.
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: brianp, lemody, mattst88
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: patch to add HAVE_DLOPEN

Description Vinson Lee 2012-08-28 02:43:56 UTC 
mesa: 971750e1cd76dabe22bf2ca83f07266837e3a2a6 (mesa)

$ scons
$ LD_LIBRARY_PATH=build/linux-x86_64-debug/gallium/targets/libgl-xlib glxinfo
Mesa warning: couldn't open libtxc_dxtn.so, software DXTn compression/decompression unavailable


57c57df7b4579b60a84062df2e64f84dd84558b5 is the first bad commit
commit 57c57df7b4579b60a84062df2e64f84dd84558b5
Author: Tapani Pälli <tapani.palli@intel.com>
Date:   Thu Aug 16 13:59:12 2012 +0300

    mesa/dlopen: use HAVE_DLOPEN instead of _GNU_SOURCE
    
    Patches changes mesa to use 'HAVE_DLOPEN' defined by configure and Android.mk
    instead of _GNU_SOURCE for detecting dlopen capability. This makes dlopen to
    work also on Android where _GNU_SOURCE is not defined.
    
    [mattst88] v2: HAVE_DLOPEN is sufficient for including dlfcn.h, remove
    	       mingw/blrts checks around dlfcn.h inclusion.
    
    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: Matt Turner <mattst88@gmail.com>
    Signed-off-by: Tapani Pälli <tapani.palli@intel.com>

:100644 100644 e8b900697f3e8d7a233c4e68fe790f55bd877b96 1e9f040ac078ccd93a5cbda2eb45a2faaf510497 M	Android.common.mk
:100644 100644 ad20c87c5051fd570768c5043d3eff3d654fdc48 9bf4e1e1f63425f69f9790a5d2cd82812fa80426 M	configure.ac
:040000 040000 31198af284c8cf68b7c68929d8087b8eb7dbaf3f 6a51d3d260833409fb84581ebfcbebfeefea03dc M	src
bisect run success
Comment 1 Matt Turner 2012-08-28 03:53:17 UTC 
(In reply to comment #0)
> $ scons

Looks like gallium.py needs to be modified to check for dlopen and define HAVE_DLOPEN. It can probably be added in the same spot where _GNU_SOURCE is defined, but I don't know anything about scons.
Comment 2 Tapani Pälli 2012-08-28 11:04:18 UTC 
Created attachment 66215 [details] [review]
patch to add HAVE_DLOPEN
Comment 3 Jose Fonseca 2012-08-30 11:11:00 UTC 
Pushed. Thanks.
Comment 4 Matt Turner 2012-08-30 16:40:10 UTC 
(In reply to comment #3)
> Pushed. Thanks.

Is that patch really right? Shouldn't that be added to gallium.py where _GNU_SOURCE is?
Comment 5 Tapani Pälli 2012-08-30 17:33:22 UTC 
(In reply to comment #4)
> (In reply to comment #3)
> > Pushed. Thanks.
> 
> Is that patch really right? Shouldn't that be added to gallium.py where
> _GNU_SOURCE is?

yes, seems I was being too hasty here, did not realize the OS specific configuration choices are made in gallium.py, sorry :/

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.