Bug 5422

Summary:	i915: ARB_f_p local parameters don't always take effect
Product:	Mesa	Reporter:	Frank Richter <resqu>
Component:	Drivers/DRI/i915	Assignee:	Default DRI bug account <dri-devel>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	normal
Priority:	high
Version:	6.4
Hardware:	x86 (IA32)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:

Description Frank Richter 2005-12-26 10:29:17 UTC

It seems that calling ProgramLocalParameter isn't always effective (in my case,
the value of the local parameter is white). Maybe the updated constants don't
get uploaded to the HW? Glancing through the HW, it seems that the
ProgramLocalParameter implementation doesn't have a mechanism to notify the
driver of the change of the constants so it can upload the new ones, or am I
missing something?...

Comment 1 Keith Whitwell 2005-12-29 22:31:48 UTC

The trigger for re-uploading parameter values is fairly blunt in the current
i915 code - any state change should trigger an upload.  The
ProgramLocalParameter fuction will cause a statechange flag to be set
(_NEW_PROGRAM), and this should cause the driver to re-upload parameters.

Can you post a simple test to demonstrate the problem?

Comment 2 Keith Whitwell 2006-01-05 21:56:13 UTC

I've added a test program for the basic ProgramLocalParam functionality to
Mesa/progs/fp.  The test works fine as far as I can tell, so I'm going to close
the bug.  Please reopen and upload a test program if you still have a problem.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.