Bug 54293

Summary: Undefined symbol sqrt firt referenced in file build/sunos-debug/glsl/libglsl.a(so_pp.os)
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: medium CC: brianp
Version: git   
Hardware: x86-64 (AMD64)   
OS: Solaris   
Whiteboard:
i915 platform: i915 features:
Attachments: define sqrtf on Sun
Add default libraries to Solaris SCons build.

Description Vinson Lee 2012-08-31 00:59:10 UTC 
$ scons
[...]
scons: Building targets ...
  Linking build/sunos-debug/glsl/glcpp/glcpp ...
Undefined                       first referenced
 symbol                             in file
sqrt                                build/sunos-debug/glsl/libglsl.a(so_pp.os)
ld: fatal: symbol referencing errors. No output written to build/sunos-debug/glsl/glcpp/glcpp


fd9afb87d81f922ea3c13a5bf2d6b17d06b43424 is the first bad commit
commit fd9afb87d81f922ea3c13a5bf2d6b17d06b43424
Author: Brian Paul <brianp@vmware.com>
Date:   Sat Aug 25 06:33:16 2012 -0600

    mesa: convert a bunch of math macros to inline functions

:040000 040000 9aaca03727b1f10f2db1e66ce3c6d74ff0062f0e f3451e762291a820e1805040c5db1345c1208225 M      src
bisect run success
Comment 1 Brian Paul 2012-08-31 02:14:31 UTC 
Created attachment 66379 [details] [review]
define sqrtf on Sun

Hi Vinson, does the attached patch help?  BTW, I don't see what the commit in question would have done to cause this.
Comment 2 Vinson Lee 2012-08-31 05:09:24 UTC 
(In reply to comment #1)
> Created attachment 66379 [details] [review] [review]
> define sqrtf on Sun
> 
> Hi Vinson, does the attached patch help?  BTW, I don't see what the commit in
> question would have done to cause this.

The attachment 66379 [details] [review] does not fix the build failure. The same error happens.
Comment 3 Vinson Lee 2012-08-31 05:21:03 UTC 
Created attachment 66381 [details] [review]
Add default libraries to Solaris SCons build.
Comment 4 Brian Paul 2012-08-31 14:26:07 UTC 
Your patch looks good to me.
Committed to master as c57fb034b19156e06e2ec25d9b06a0e174d861c9
Committed to 9.0 branch as 7b676fd738691dba283fb17626026774b790cc0d

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.