| Summary: | [Bisected i965]Oglc fbo(mipmap.manualCubeMap) fails | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | lu hua <huax.lu> |
| Component: | Drivers/DRI/i965 | Assignee: | Anuj Phogat <anuj.phogat> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | idr, xunx.fang |
| Version: | git | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
lu hua
2012-08-31 02:17:23 UTC
Cubemap textures would require separate fragment shader program while using glsl version of _mesa_meta_GenerateMipmap(). I clearly missed to take care of this in my patch on mesa (0fc11a2). I'll soon send out a patch to fix this issue. It also fails on Ironlake. It also happens on mesa 9.0 branch(commit:6886da783ac2fc549b4) fbo(mipmap.manualCubeMap) fails on Pineview with mesa master branch. Bisect shows:0fc11a24c85413a335b87bc34659d2381fd6670c is the first bad commit. This patch fixes the cause of failing test: http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg26374.html Patch is still under review on mailing list. Please feel free to test the patch. commit 299acac on mesa master fixes this issue. float-texture(mipmap.manual) still fails on master branch. fbo(mipmap.manualCubeMap) and max_values(advanced.textureSize.thin-1d) fixed on master branch by commit:299acac849eb8506de9760c94c6e8e8b1046d909. commit 299acac849eb8506de9760c94c6e8e8b1046d909 Author: Anuj Phogat Date: Fri Aug 31 13:51:39 2012 -0700 _mesa_meta_GenerateMipmap: Support all texture targets by generating shaders at runtime float-texture(mipmap.manual) failure is resolved by following commit on mesa master. commit eb1d87fb945783448cc40ad43c9cd4d98002d424 Author: Anuj Phogat <anuj.phogat@gmail.com> Date: Thu Sep 20 13:17:19 2012 -0700 meta: Add on demand compilation of per target shader programs A call to glGenerateMipmap() follows the generation of a relevant shader program in setup_glsl_generate_mipmap(). To support all texture targets and to avoid compiling shaders everytime, per target shader programs are compiled on demand and saved for the next call. Fixes float-texture(mipmap.manual): See Comment 6: https://bugs.freedesktop.org/show_bug.cgi?id=54296 NOTE: This is a candidate for stable branches. Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Brian Paul <brianp@vmware.com> float-texture(mipmap.manual) still fails on ironlake with master branch (commit: 60e610e0426d79fc9080df1a9ae0a6be39af1380). It fixed by commit eb1d87fb945783448 on Ivybridge and Sandybridge. commit eb1d87fb945783448cc40ad43c9cd4d98002d424 Author: Anuj Phogat <anuj.phogat@gmail.com> Date: Thu Sep 20 13:17:19 2012 -0700 meta: Add on demand compilation of per target shader programs I tested float-texture mipmap.manual on ironlake and it fails with same logs on mesa master at 174d44a which is before my changes for GenerateMipmap(). So, this doesn't seem to be a regression caused by commit 0fc11a2. Could you please raise a separate bug for this failure and close this one? Yes,float-texture mipmap.manual doesn't caused by commit 0fc11a24c854 on ironlake. Close this bug. Veridied.Fixed by commit eb1d87fb945783448cc40ad43c9cd4d98002d424. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.