Bug 54322

Summary:	HarfBuzz build fails on Clang/ARM r161757 with -Werror
Product:	HarfBuzz	Reporter:	Philippe Liard <pliard>
Component:	src	Assignee:	Behdad Esfahbod <freedesktop>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	freedesktop
Version:	unspecified
Hardware:	ARM
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Trivial patch fixing the compilation error

Description Philippe Liard 2012-08-31 13:53:52 UTC

Created attachment 66405 [details] [review]
Trivial patch fixing the compilation error

The implicit -Wincompatible-pointer-types warning raises typing issues in contrib/harfbuzz-freetype.c.

Note that this applies to the old version of HarfBuzz cloned from http://anongit.freedesktop.org/git/harfbuzz.old.git/ and used in Chromium.

Please find attached a patch fixing this.

Comment 1 Behdad Esfahbod 2012-08-31 14:45:17 UTC

Fixed.  Thanks.

Comment 2 Philippe Liard 2012-08-31 14:47:27 UTC

Thanks Behdad for doing this quickly!

Comment 3 Behdad Esfahbod 2012-08-31 14:59:50 UTC

You're welcome.  Hopefully we remove that code from Chromium really soon...

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.