Bug 54455

Summary:	Port to GStreamer 1.0
Product:	libcanberra	Reporter:	Dominique Leuenberger <dominique-freedesktop.org>
Component:	Unspecified	Assignee:	Lennart Poettering <lennart>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	bugzilla
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Port to GStreamer 1.0

Description Dominique Leuenberger 2012-09-03 18:24:32 UTC

I made an initial attempt at porting libcanberra to GStreamer 1.0 (0.11.93 actually).

The entire gnome stack is migrating, and GStreamer 1.0 is assumed for Gnome 3.6;

as such, switching any other underlying tool as well is just logical.

Comment 1 Dominique Leuenberger 2012-09-03 18:28:44 UTC

Created attachment 66568 [details] [review]
Port to GStreamer 1.0

Comment 2 Bastien Nocera 2012-09-24 14:54:21 UTC

Comment on attachment 66568 [details] [review]
Port to GStreamer 1.0

Review of attachment 66568 [details] [review]:
-----------------------------------------------------------------

Did a port too, and realised that yours was already in bugzilla.

::: configure.ac
@@ +383,4 @@
>          [gstreamer=auto])
>  
>  if test "x${gstreamer}" != xno ; then
> +    PKG_CHECK_MODULES(GST, [ gstreamer-1.0 >= 0.10.15 ],

You can remove the version here, it's not relevant anymore.

::: src/gstreamer.c
@@ +307,4 @@
>  
>          sinkelement = GST_ELEMENT(data);
>  
> +        caps = gst_pad_query_caps(pad, NULL);

I had:
-        caps = gst_pad_get_caps(pad);
+        caps = gst_pad_get_current_caps(pad);
instead.

Comment 3 Lennart Poettering 2012-09-24 14:55:33 UTC

Ah, will merge and release. Sorry for the delay.

Comment 4 Lennart Poettering 2012-09-25 00:11:40 UTC

Applied. Thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.