Bug 54498

Created attachment 66633 [details]
bt + console logs on 3.6

On pc Debian x86-64 with 3.6 sources updated today, I reproduced the bug.

(I'll try to reproduce this on master since it's compiling right now).

Marking as MAB and prioritizing

Critical: data loss potential

High: Everything is here to reproduce, including bt, potential for quite a few people to be affected. Plus, regression = no good

I guess it is the same bug as 
bug 54621 : EDITING: CRASH in .ods documents with lots of (conditional) formatting
and 
bug 54719 : Crash when deleting a row in a sheet with conditional formatting

@Markus: do you agree?

Best regards. JBF

(In reply to comment #3)
> I guess it is the same bug as 
> bug 54621 : EDITING: CRASH in .ods documents with lots of (conditional)
> formatting
> and 
> bug 54719 : Crash when deleting a row in a sheet with conditional formatting
> 
> @Markus: do you agree?
> 
> Best regards. JBF

No. This onelooks like a normal calc bug. But I might have a look at it when i fixed the serious cond format bugs.

Did anybody here having this bug use an official LibO build? Or does this only happen with a tinderbox build an own builds?

Created attachment 67131 [details]
Much simpler test document

I've reduced the original document to make it easier to debug.

Steps to induce the crash

1. Open the document,
2. Select any row header, right-click, and click Delete Rows.
3. Crash.

@Kohei:
Thank you for the new, reduced Sample document. Indeed it seems to reproduce the same crash I observed.

With" Much simpler test document", 3.6.2.1 and Koheis steps, behavior seemed to be differen. View on spreadsheet remained, but LibO stopped responding, "busy" mouse pointer appearED, and after 10s or so error message appeared: "Runtime Error " Programd C:\.....\soffice.bin    This application has requested the Runtime to trminate it in an unusual way. Please contact ... . " After <ok> in that message LibO dissappeared.
But that was reproducible only 1 time, in further tests sometimes I did not see any crash, sometimes the same as during tests for original report. So all that only seem to be different manifestations of the same problem.

With "Sample Document" and "my way" I saw an immediate crash, Libo disappears immediately. I reproduced an identical crash 5 times (each attempt with crash) with Row 19 in "Much simpler test document".

Created attachment 67178 [details]
simpler test case

Really simple test case. Only contains one conditional format and nearly no content anymore.

*** Bug 54852 has been marked as a duplicate of this bug. ***

*** Bug 54621 has been marked as a duplicate of this bug. ***

*** Bug 54733 has been marked as a duplicate of this bug. ***

Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e6bca122176cdb2b6e822fc933f159dc3e3c8d46

don't delete ranges in ScRangeList::UpdateReference, fdo#54498



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a182026fce922a9f69e8da76d46e87e7188a4e9

don't use delete with remove_if, related fdo#54498



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Hi Markus,

I did some tests on my own files with updated master (Version 3.7.0.0.alpha0+ (Build ID: 9057689)). For the moment no crash when deleting a row in a spreadsheet with conditional formattings like https://bugs.freedesktop.org/attachment.cgi?id=66911 in bug 54719 (duplicate of a duplicate of this one :-) )
Files with CF saved with LO 3.6.2.1 and making LO 3.6.2.1 and LO 3.6.3.0+ crashing (seg fault) on reloading or reopening the file (the files are opened without problem with LO 3.5.6, so no data loss), are opened without problem by this build of the master.

Some other tests in progress.
Best regards. JBF

Don't know if this will help, but I have no problems with crashes when deleting any of the rows in any of the test files using Version 3.6.0.4 (Build ID: 932b512) in Windows XP.  Tested 6 or 7 times with the first file...

@Charles McCullough:
<http://wiki.documentfoundation.org/BugReport_Details#Version>

Markus Mohrhard committed a patch related to this issue.
It has been pushed to "libreoffice-3-6-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5343c2fc6d00c75226ddb78b5300d3e34db53ddb&g=libreoffice-3-6-2

fix crash when updating conditional formats, fdo#54498


It will be available already in LibreOffice 3.6.2.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

*** Bug 54855 has been marked as a duplicate of this bug. ***

Works fine with Server Installation of  "LibreOffice  3.6.4.0+  English UI/ German Locale [Build-ID: a4b919d],{tinderbox: Win-x86@9 pull time 2012-10-10 19:11:32}  on German WIN7 Home Premium (64bit). I worked on sample documents for crashes with that Version 1/2 hour intensively without any problems.