| Summary: | [regression] 33% performance regression on GLBenchmark2.1-Egypt from ETC1 support | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | libo <bo.c.li> |
| Component: | Drivers/DRI/i965 | Assignee: | Eric Anholt <eric> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | high | CC: | idr, kenneth, mengmeng.meng |
| Version: | 9.0 | ||
| Hardware: | x86 (IA32) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
|
Description
libo
2012-09-06 06:17:27 UTC
Ian/Ken, can you reproduce this? Those two commits are right next to each other, and are the enabling of ETC1 support on non-ETC1-supporting hw: commit a5a34b153d494ad4374e7b2c8ea13b1073a887e2 Author: Chad Versace <chad.versace@linux.intel.com> Date: Mon Jun 18 18:25:25 2012 -0700 intel: Enable GL_OES_compressed_ETC1_RGB8_texture We couldn't reproduce this. We got identical performance in the ETC1 path and the S3TC path. Ian, any idea to diagnose this issue? Patches on the list. Apparently they were testing with a GLB2.5 build using the GLB2.1 data, which makes different choices for texture formats (pretty much invalidating the point of having compatibility with the old datasets). (In reply to comment #5) With the path "i965: Fix validation of ETC miptrees", GLBenchmark2.1 Egypt performance improve ~100%(70fps → 148fps). Environment: ---------------------- Platform:IVB mesa:(master)dc613f11ddf1f3a6e10c2d99830fb1a84fdb55b2 kernel:(drm-intel-fixes)b45305fce5bb1abec263fcff9d81ebecd6306ede case:GLBenchmark2.1 GLB2_EgyptTestStandard(2000) commit 46386816a77c6e5751a0685776c0a6320f46f8fe Author: Eric Anholt <eric@anholt.net> Date: Tue Dec 18 12:03:49 2012 -0800 i965: Fix validation of ETC miptrees. Please merge it into 9.0 branch because the issue still exists on 9.0 branch. (In reply to comment #7) > commit 46386816a77c6e5751a0685776c0a6320f46f8fe > Author: Eric Anholt <eric@anholt.net> > Date: Tue Dec 18 12:03:49 2012 -0800 > > i965: Fix validation of ETC miptrees. Eric, do you have plan to cherry-pick? Eric/Ian, please decide if you want to cherry-pick to 9.0. I went ahead and picked it to 9.0 branch (ba73bea), but I doubt anyone will care. To the best of my knowledge, no distro is still shipping 9.0. I don't care about 9.0 either. I just wanted to close this one. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.