Bug 54807

Summary: [G33] missing textures in Xonotic
Product: Mesa Reporter: JS <js314592>
Component: Drivers/DRI/i915Assignee: Kenneth Graunke <kenneth>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: idr, kenneth
Version: git   
Hardware: Other   
OS: All   
i915 platform: i915 features:
Attachments: screenshot

Description JS 2012-09-12 09:44:15 UTC
Created attachment 67030 [details]

see screenshot
driver i915g renders textures right
Comment 1 Kenneth Graunke 2012-09-14 18:18:10 UTC
According to Michael[*], this is a recent regression.

Judging by the dates, I'm guessing it may be my fault...wondering if the ProgramStringNotify replacement isn't taking effect.  Need to dig out one of these machines...

[*] http://www.phoronix.com/scan.php?page=article&item=intel_gma3150_quantal&num=3
Comment 2 Kenneth Graunke 2012-09-14 21:33:59 UTC
I can reproduce this, but it looks like it isn't what I thought.  I guess I'll have to bisect.
Comment 3 Kenneth Graunke 2012-09-15 09:39:28 UTC
And the results are in!

fb4a34e60eb4c1bdc7b0fdcd98d1bf3038c354e8 is the first bad commit
commit fb4a34e60eb4c1bdc7b0fdcd98d1bf3038c354e8
Author: Marek Olšák <maraeo@gmail.com>
Date:   Mon Apr 16 16:04:52 2012 +0200

    mesa: set _NEW_VARYING_VP_INPUTS flag only if fixed-func VP is enabled & valid

    Reviewed-by: Brian Paul <brianp@vmware.com>
    Reviewed-by: Mathias Fröhlich <Mathias.Froehlich@web.de>

:040000 040000 2a583d253734ad89eca25940f7250d7c2755a311 298006f25f73d44d5694b47b72f44f9e945b6260 M      src

Now to look into what exactly those do...
Comment 4 Kenneth Graunke 2012-09-16 08:19:50 UTC
This turned out to be the same as #49127.

Patch on mailing list:
Comment 5 Kenneth Graunke 2012-10-06 14:48:48 UTC
Fixed on master by:

commit 7fa0f10cd85ccb5afbc3a961164011de70970ff3
Author: Kenneth Graunke <kenneth@whitecape.org>
Date:   Mon Oct 1 20:11:38 2012 -0700

    mesa: Flag _NEW_VARYING_VP_INPUTS when TexEnv programs are active.
    The idea here is to not flag _NEW_VARYING_VP_INPUTS when shaders (either
    GLSL or ARB vp/fp) are in use.  If either TNL or TexEnv programs are
    active, at least one stage is using fixed function.
    On Pineview, fixes 20 Piglit, 60 oglconforms, and 7 ES 1.1 conformance
    tests, as well as missing textures in Xonotic.  These were all
    regressions since commit fb4a34e60eb4c1bdc7b0fdcd98d1bf3038c354e8.
    NOTE: This is a candidate for the 9.0 branch.
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=49127
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54807
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>

Fixed on 9.0 by 8491e03b2befd7e9d16c5d17f95a83d91c5b16c9.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.