| Summary: | crash in cairo-tor-scan-converter while opening a pdf | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Riccardo Magliocchetti <riccardo.magliocchetti> |
| Component: | general | Assignee: | Carl Worth <cworth> |
| Status: | RESOLVED FIXED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | matttbe |
| Version: | 1.12.2 | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | The result of _cairo_debug_print_polygon(). | ||
|
Description
Riccardo Magliocchetti
2012-09-12 17:13:23 UTC
The file loads fine here. I have to zoom out to make it crash. The crash is a NULL pointer dereference in dec(), the struct edge *e argument is NULL. git bisect unhelpfully points at the new compositor architecture (Why does that commit remove asserts from the scan converter?): git bisect start # good: [0540bf384aed344899417d3b0313bd6704679c1c] ps: improve formatting of fallback image comment git bisect good 0540bf384aed344899417d3b0313bd6704679c1c # bad: [65a954d5bab9ab6fed15bd98b7018aca2fc50107] test-surfaces: compilation fixes git bisect bad 65a954d5bab9ab6fed15bd98b7018aca2fc50107 # skip: [af9fbd176b145f042408ef5391eef2a51d7531f8] Introduce a new compositor architecture git bisect skip af9fbd176b145f042408ef5391eef2a51d7531f8 _cairo_debug_print_polygon() against the polygon that causes this produces something which doesn't look correct in show-polygon, which means the error might be elsewhere. Created attachment 67144 [details]
The result of _cairo_debug_print_polygon().
Because the asserts were a crutch and implied the code was buggy. :-p commit 797441093a8346003552e0cf89aef2a644ff53ab Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Thu Sep 27 15:21:42 2012 +0100 tor: Fudge the edge if it is projected into a point If we generate an edge (through polygon-intersect) where its end-points lie outside the line definition then it is possible for that line to be degenerate under sample grid projection. Apply a fudge factor to prevent explosions as otherwise we reject an edge whose height is not strictly 0. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54822 Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.