Bug 54870

Summary:	refactor McdStorage in preparation for GVariant'izing it
Product:	Telepathy	Reporter:	Simon McVittie <smcv>
Component:	mission-control	Assignee:	Simon McVittie <smcv>
Status:	RESOLVED FIXED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium	CC:	jonny.lamb
Version:	unspecified	Keywords:	patch
Hardware:	Other
OS:	All
URL:	http://cgit.freedesktop.org/~smcv/telepathy-mission-control/log/?h=storage-refactor-54870
Whiteboard:	r+
i915 platform:		i915 features:
Bug Depends on:	35896
Bug Blocks:	54872

Description Simon McVittie 2012-09-13 14:59:20 UTC

This is a (hopefully) reviewable piece of refactoring/documentation/etc. for account storage plugins. It builds on my branch from Bug #35896.

Comment 1 Jonny Lamb 2012-09-27 14:59:43 UTC

I started reviewing from a04220ab092e417f451d8ce (McdStorage: include flagging-as-secret in update_storage()) as the rest has already been reviewed and merged to master.

G_SIGNAL_DEPECATED! I learned something new today.

+G_DEPRECATED_FOR (something that is actually implemented)

:-D

Your branches are pretty easy to look at, thanks! I also half want to ask you to add something (perhaps more obviously) wrong so it looks like I'm actually doing my job.

++

Comment 2 Simon McVittie 2012-10-04 15:20:35 UTC

Thanks, pushed; will be in 5.15.0. I'll leave the branch in my git repository for now, since it indicates where the next one starts.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.