Bug 54914

Summary: regression in 9.0/master due to c8a86f717f8e3020
Product: Mesa Reporter: Timo Aaltonen <tjaalton>
Component: Drivers/DRI/i915Assignee: Ian Romanick <idr>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Timo Aaltonen 2012-09-14 09:32:20 UTC 
we've bisected a bug in i915_dri.so which was caused by this commit:

commit c8a86f717f8e30204c615d06bcec159410ac06c5
Author: Brian Paul <brianp@vmware.com>
Date:   Fri Aug 31 08:33:31 2012 -0600

    mesa: move IS_NEGATIVE() and DIFFERENT_SIGNS() to macros.h

and it was discussed briefly on #intel-gfx:

< ickle> let me guess: GLboolean is a char
< ickle> yup.
< ickle> DIFFERENT_SIGNS() always return 0 as (unsigned char)(1<<31) == 0
< ickle> also note that fi_type isn't well defined when sizeof(int)!=4

the downstream bug is

https://bugs.launchpad.net/ubuntu/quantal/+source/mesa/+bug/1047306

causing unity/compiz segfaults with hw using the dri driver. Reverting just that commit was verified to work.
Comment 1 Timo Aaltonen 2012-09-17 07:42:42 UTC 
this bug was actually not in 9.0 but only master, we just had a hybrid branch due to either a mistaken merge from master right after 9.0 got branched, or it got branched from an earlier commit that we had pulled from master.

Either way, closing as fixed by f73ffacbf0c65ad.

*** This bug has been marked as a duplicate of bug 54365 ***

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.