Bug 54947

Summary: src/glsl/glcpp/pp.c:162: undefined reference to `glcpp_parser_parse'
Product: Mesa Reporter: Vinson Lee <vlee>
Component: glsl-compilerAssignee: Ian Romanick <idr>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: medium CC: airlied, kallisti5, kenneth, omcfadde
Version: git   
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2012-09-15 02:04:07 UTC 
mesa: 8f9bae615db5c058e3b6ce7f3f8e2262d59640bf

$ scons
[...]
  Linking build/linux-x86_64-debug/glsl/builtin_compiler ...
build/linux-x86_64-debug/glsl/glcpp/glcpp-parse.o: In function `yyparse':
build/linux-x86_64-debug/glsl/glcpp/glcpp-parse.c:1779: undefined reference to `yylex'
build/linux-x86_64-debug/glsl/glcpp/pp.o: In function `glcpp_preprocess':
src/glsl/glcpp/pp.c:162: undefined reference to `glcpp_parser_parse'
collect2: ld returned 1 exit status

53d46bc787318ccf9911fdd1d5fe99ee4db7f41a is the first bad commit
commit 53d46bc787318ccf9911fdd1d5fe99ee4db7f41a
Author: Dave Airlie <airlied@gmail.com>
Date:   Fri Sep 14 19:59:54 2012 +1000

    glcpp: fix abuse of yylex

    So glcpp tried to workaround yylex its own way, but failed,
    do it properly.

    This fixes another crash found after fixing the first crash.

    this is a candidate for 9.0 and stable branches

    Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
    Signed-off-by: Dave Airlie <airlied@redhat.com>

:040000 040000 98d8cdf206d5af2545c8d0bb5b95519c82d9da32 96a734c121f0cdeeebf86f39710f8a4ca81a18ab M      src
bisect run success
Comment 1 Dave Airlie 2012-09-15 02:05:19 UTC 
oh hi there multiple build systems.

someone with some scons will have to fix this at a guess.
Comment 2 Vinson Lee 2012-09-30 18:47:05 UTC 
commit e78ebbc5f9448d459b57884d90b0a6496294c1dd
Author: Brian Paul <brianp@vmware.com>
Date:   Sat Sep 15 09:01:02 2012 -0600

    scons: add new -p (prefix) options for yacc
    
    These were recently added to the Makefiles.
Comment 3 Oliver McFadden 2012-10-02 00:19:50 UTC 
Please also see Adrian's patch for the Android build system on the mesa-dev mailing list, and my replies.

Subject: [Mesa-dev] [PATCH] adroid : glcpp: fix abuse of yylex
Message-Id: <1348843000-2060-1-git-send-email-adrian.m.negreanu@intel.com>

I am currently awaiting Dave's Reviewed-by tag, then I'll push the patch (with subject typo fix.)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.