Bug 55047

Summary: [855gm regression] Boots noisely with the lid close (but works!)
Product: DRI Reporter: Chris Wilson <chris>
Component: DRM/IntelAssignee: Daniel Vetter <daniel>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: medium CC: ben, chris, daniel, florian, jbarnes
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
dmesg
none
dmesg drm.debug=6
none
fixup ch7xxxx get hw state callback
none
After dvo get_state patch.
none
ch7xxx fixup, v2
none
patched dmesg, v2
none
patched dmesg, v2 none

Description Chris Wilson 2012-09-18 10:44:35 UTC
Created attachment 67320 [details]
dmesg
Comment 1 Chris Wilson 2012-10-11 08:37:36 UTC
Created attachment 68428 [details]
dmesg drm.debug=6
Comment 2 Daniel Vetter 2012-10-11 09:11:11 UTC
Created attachment 68431 [details] [review]
fixup ch7xxxx get hw state callback

Let's hope this works ...
Comment 3 Chris Wilson 2012-10-11 11:21:07 UTC
Created attachment 68433 [details]
After dvo get_state patch.

Doesn't appear to be the solution. :(
Comment 4 Daniel Vetter 2012-10-11 15:11:36 UTC
Created attachment 68442 [details] [review]
ch7xxx fixup, v2

I've missed that the connector sanitize code doesn't call disable. Also some additional debug printks. Please attach drm.debug=0xe dmesg with this patch applied.
Comment 5 Chris Wilson 2012-10-11 15:30:07 UTC
Created attachment 68443 [details]
patched dmesg, v2

Almost too quiet...
Comment 6 Chris Wilson 2012-10-11 15:43:30 UTC
Created attachment 68444 [details]
patched dmesg, v2
Comment 7 Chris Wilson 2012-10-11 16:18:49 UTC
Retesting patch 1, also silences the critics. I've arranged for myself to be taken outside and shot.
Comment 8 Chris Wilson 2012-10-11 16:48:37 UTC
commit e998eae4cf2804260a92a4eed465ff7f17e0d722
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Oct 11 18:43:52 2012 +0200

    drm/i915/dvo-ch7xxx: fix get_hw_state
    
    The boot-up state seems to be all-zeros, so it's safer to check for
    the bits that need to be set when the dvo encoder is in the dpms on
    state, than checking the bits we set when it's in the off state.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55047
    Tested-by: Chris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Comment 9 Florian Mickler 2012-10-23 21:03:23 UTC
A patch referencing this bug report has been merged in Linux v3.7-rc2:

commit 4afa0ace429624fde392b29d05a803672a41192e
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Oct 11 18:43:52 2012 +0200

    drm/i915/dvo-ch7xxx: fix get_hw_state

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.