| Summary: | [PATCH] make LinkRendition properties available in Qt4 frontend | ||
|---|---|---|---|
| Product: | poppler | Reporter: | Tobias Koenig <tobias.koenig> |
| Component: | qt4 frontend | Assignee: | poppler-bugs <poppler-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
Patch to extend Poppler::LinkRendition in Qt4 frontend
Updated patch Updated patch |
||
Created attachment 67766 [details] [review] Updated patch Extended previous patch by adding test function for referenced ScreenAnnotation. Could you try to avoid whitespace only changes? I know you are actually fixing stuff but it makes the patches a bit harder to review. The "delete linkAction;" removal seems like it does not belong to this patch? We don't have an enum for the operations thing in the poppler core? Maybe it's worth adding? Could you keep the old LinkRendition constructor and mark it as deprecated so we don't break the ABI unccessesarly? Created attachment 68242 [details] [review] Updated patch I have updated the patch according to the review comments now. The 'delete link' is still in place, because deleting the link object at this place is wrong and just worked by coincidence. Using the new LinkRendition object with a ScreenAnnotation uncovers that. The constructor of LinkRendition still takes an integer for the operation parameter, because I don't see a clean way to make the enum from the ::LinkRendition class available in the header file. Internally however the new enum is used. Commited :-) |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 67756 [details] Patch to extend Poppler::LinkRendition in Qt4 frontend The attached patch makes the operation and JavaScript properties of the LinkRendition class available in the Poppler::LinkRendition class of the Qt4 frontend.