Bug 55483

Summary:	Allow "GNOME3" as AutostartCondition desktop name
Product:	desktop-file-utils	Reporter:	Alexandre Rostovtsev <tetromino>
Component:	general	Assignee:	Vincent Untz <vuntz>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	medium	CC:	a9016009, gnome
Version:	unspecified
Hardware:	Other
OS:	All
URL:	https://bugzilla.gnome.org/show_bug.cgi?id=685005
Whiteboard:
i915 platform:		i915 features:

Description Alexandre Rostovtsev 2012-10-01 00:55:38 UTC

Gnome 3.x from has been using "AutostartCondition=GNOME3 ..." in its autostart .desktop files because, for historical reasons, AutostartCondition=GNOME is tied to gconf and gnome 2; see http://git.gnome.org/browse/gnome-session/commit/?id=58ebdfac223e6246323a6fcc452221a7581ed868

desktop-dile-validate marks these files as invalid because handle_autostart_condition_key() expects the desktop name to be in the show_in_registered list, but "GNOME3" is not in that list.

Matthias Clasen has stated that since AutostatCondition was not formally accepted into the autostart spec, "it is best to simply accept the fact that GNOME3 is now in use as a condition" : https://bugzilla.gnome.org/show_bug.cgi?id=685005

I therefore suggest that handle_autostart_condition_key() be modified to accept "GNOME3"; one possibility would be to check against a separate list (e.g. "autostart_condition_registered") which is a superset of show_in_registered.

Comment 1 Vincent Untz 2012-10-01 11:43:52 UTC

We also need to support the "GSettings" condition.

Note that when adding support for "GNOME3", it'd be nice to check if the second word is if-session or unless-session, and to check there's a third one.

Comment 2 Vincent Untz 2012-10-03 13:56:26 UTC

Fixed in git.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.