Bug 55502

Summary: Shell BASIC function with invalid Pathname command causes hang with bSync=true and bSync=false
Product: LibreOffice Reporter: Viktor Mileikovskyi <v_mil>
Component: BASICAssignee: Not Assigned <libreoffice-bugs>
Status: NEW --- QA Contact:
Severity: major    
Priority: high CC: jmadero.dev, todventtu, v_mil
Version: Inherited From OOo   
Hardware: All   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: The file has two macroses. See Attachment full description:

Description Viktor Mileikovskyi 2012-10-01 15:38:36 UTC
Created attachment 67931 [details]
The file has two macroses. See Attachment full description:

Calling Shell causes hang if Pathname not found.

Steps to reproduce (assumed that a command sp8bnrf2kx9s is invalid):
1. Download TestShell.ods
2. SAVE ALL DOCUMENTS IN LIBREOFFICE! Possible hanging!
3. Open TestShell.ods. Allow macros.
4. Press one of two buttons

Current behaviour
    Hang. Only kill helps
Expected behaviour
    Rising error 53: File not found.

Operating system:
    Ubuntu 12.04 x86-64

Attachment full description:
    The file has two macroses associated with two buttons:
Sub TestWait 'Associated with "TEST SHELL WITH WAITING"
    shell("sp8bnrf2kx9s",6,"",True)
End Sub
Sub TestNoWait 'Associated with "TEST SHELL WITHOUT WAITING"
    shell("sp8bnrf2kx9s",6,"",False)
End Sub
Comment 1 Beluga 2014-11-06 12:35:51 UTC
On 4.3.3. I get "File not found" and crash.

On 4.4 I get:

Assertion failed!
Program: ...gram Files (x86)\LibreOfficeDev 4\program\sblo.dll File : C:\cygwin\home\tinderbox\master\include\rtl/ustring.hxx Line: 421

Expression: index >= 0 &&static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())

Win 7 64-bit 4.3.3.2 and Version: 4.4.0.0.alpha1+
Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f
TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51
Comment 2 Joel Madero 2015-01-06 19:25:37 UTC
Just a follow-up.

Confirmed on:
Ubuntu 14.04
LibreOffice 3.3 (inherited from OOo).

Are we 100% sure that this isn't an enhancement request?

Anyways, Updating version to reflect that I've confirmed on the oldest version (and thus not a regression).

Also:
Lowering priority.

Major - hang but not going to affect the majority of users (probably going to affect a tiny fraction of users). Critical is reserved for crashes/hangs that will affect a large number of users.

High - default is fine here.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.