Bug 55539

Summary:	Searching Pidgin log store matches search against tags
Product:	Telepathy	Reporter:	Will Thompson <will>
Component:	logger	Assignee:	Telepathy bugs list <telepathy-bugs>
Status:	RESOLVED MOVED	QA Contact:	Telepathy bugs list <telepathy-bugs>
Severity:	normal
Priority:	medium
Version:	git master
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	demonstrates this bug in the pidgin log store

Description Will Thompson 2012-10-02 13:20:20 UTC

Created attachment 67992 [details]
demonstrates this bug in the pidgin log store

The Pidgin log store searches by just matching the query against mmaped log files using strstr(). http://cgit.freedesktop.org/telepathy/telepathy-logger/tree/telepathy-logger/log-store-pidgin.c#n901

This is great, except that it matches the names of tags as well as the contents of your messages. See the attached patch, which changes the test suite to search for "font". The only occurrence of "font" in the test suite's pidgin logs is as "<font …>" or "</font>", so it shouldn't match, but does.

The XML log store doesn't have this bug. It searches your logs with … a regex … to match XML. Which I suppose works, but… http://cgit.freedesktop.org/telepathy/telepathy-logger/tree/telepathy-logger/log-store-xml.c#n1550

Comment 1 GitLab Migration User 2019-12-03 19:31:43 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/telepathy/telepathy-logger/issues/29.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.