Summary: | Memory Leaks in arbprogparse.c | ||
---|---|---|---|
Product: | Mesa | Reporter: | Roy Walmsley <roy.walmsley> |
Component: | Mesa core | Assignee: | mesa-dev |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | low | ||
Version: | git | ||
Hardware: | x86 (IA32) | ||
OS: | Windows (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
patch for leak 1
patch for leak 2 |
Description
Roy Walmsley
2006-01-10 01:03:44 UTC
Could you just provide a patch with your fixes? Thanks. Created attachment 5505 [details] [review] patch for leak 1 This patch should fix the first of the two leaks (I don't have a test case so I cannot say for sure). Created attachment 5506 [details] [review] patch for leak 2 The only time the "name" property of struct var_cache is assigned a non-dummy value is in line 644, and it's not given a newly allocated value, but it's assigned a pointer into a chunk of memory. So we shouldn't free it, and we don't have to strdup() the dummy values either. I don't have a test case, though. I've checked in your changes. I also added a comment to the var_cache->name field that it's not to be freed. The patches most likely fixed the bug; reopen if they didn't. Mass version move, cvs -> git |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.