Bug 55645

Summary:

Out-of-tree builds fail with gen4asm installed

Product:

xorg

Reporter:

Josh Triplett <josh>

Component:

Driver/intel

Assignee:

Chris Wilson <chris>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

Version:

git

Hardware:

All

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
[PATCH] Fix out-of-tree builds with intel-gen4asm installed	none

Description Josh Triplett 2012-10-05 00:12:50 UTC

With gen4asm installed, out-of-tree builds fail with errors like this:

m4: cannot open `field_backward.g4a': No such file or directory

Looks like the make rules for gen4asm files reference the source files via their basenames without using srcdir, which only works for in-tree builds.

This breaks when trying to build the current Intel driver on ChromeOS, which uses out-of-tree builds for everything.

Comment 1 Josh Triplett 2012-10-05 00:51:16 UTC

Created attachment 68099 [details] [review]
[PATCH] Fix out-of-tree builds with intel-gen4asm installed

The attached patch fixes this bug.

Comment 2 Chris Wilson 2012-10-05 09:28:54 UTC

commit 5b74a2dc5270094810ec0cf8039fd3b3ab0815b5
Author: Josh Triplett <josh@joshtriplett.org>
Date:   Thu Oct 4 17:48:24 2012 -0700

    Fix out-of-tree builds with intel-gen4asm installed
    
    The make rules to compile shaders with intel-gen4asm referenced the .g4a
    source files without using $(srcdir), which broke out-of-tree builds.
    Reference .g4a source files via $(srcdir), and add $(srcdir) to m4's
    include path, fixing out-of-tree builds.
    
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=55645
    Signed-off-by: Josh Triplett <josh@joshtriplett.org>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.