Bug 55888

mesa: 7b01bc1e4c9675d3b7519c8743cecc09ffb4317a

$ scons
[...]
  Compiling src/gallium/auxiliary/util/u_debug.c ...
src/gallium/auxiliary/util/u_debug.c: In function ‘debug_dump_transfer_bmp’:
src/gallium/auxiliary/util/u_debug.c:626:23: warning: passing argument 1 of ‘pipe_get_tile_rgba’ from incompatible pointer type [enabled by default]
src/gallium/auxiliary/util/u_tile.h:77:1: note: expected ‘struct pipe_transfer *’ but argument is of type ‘struct pipe_context *’
src/gallium/auxiliary/util/u_debug.c:626:23: warning: passing argument 3 of ‘pipe_get_tile_rgba’ makes integer from pointer without a cast [enabled by default]
src/gallium/auxiliary/util/u_tile.h:77:1: note: expected ‘uint’ but argument is of type ‘void *’
src/gallium/auxiliary/util/u_debug.c:626:23: warning: passing argument 7 of ‘pipe_get_tile_rgba’ makes pointer from integer without a cast [enabled by default]
src/gallium/auxiliary/util/u_tile.h:77:1: note: expected ‘float *’ but argument is of type ‘int’
src/gallium/auxiliary/util/u_debug.c:626:23: error: too many arguments to function ‘pipe_get_tile_rgba’
src/gallium/auxiliary/util/u_tile.h:77:1: note: declared here


369e46888904c6d379b8b477d9242cff1608e30e is the first bad commit
commit 369e46888904c6d379b8b477d9242cff1608e30e
Author: Marek Olšák <maraeo@gmail.com>
Date:   Mon Oct 8 04:06:42 2012 +0200

    gallium: unify transfer functions
    
    "get_transfer + transfer_map" becomes "transfer_map".
    "transfer_unmap + transfer_destroy" becomes "transfer_unmap".
    
    transfer_map must create and return the transfer object and transfer_unmap
    must destroy it.
    
    transfer_map is successful if the returned buffer pointer is not NULL.
    If transfer_map fails, the pointer to the transfer object remains unchanged
    (i.e. doesn't have to be NULL).
    
    Acked-by: Brian Paul <brianp@vmware.com>