| Summary: |
org.freedesktop.timedate1 SetNTP should not always enable the ntpd.service |
| Product: |
systemd
|
Reporter: |
twelve.eighty |
| Component: |
general | Assignee: |
systemd-bugs |
| Status: |
RESOLVED
NOTOURBUG
|
QA Contact: |
systemd-bugs |
| Severity: |
normal
|
|
|
| Priority: |
medium
|
|
|
| Version: |
unspecified | |
|
| Hardware: |
Other | |
|
| OS: |
Linux (All) | |
|
| Whiteboard: |
|
|
i915 platform:
|
|
i915 features:
|
|
|---|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
When using systemd, NetworkManager, NTP and then networkmanager-dispatcher-ntpd to start NTP after NetworkManager has established a connection, the ntpd.service service gets enabled by a call to gdbus: gdbus call \ --system \ --object-path /org/freedesktop/timedate1 \ --dest org.freedesktop.timedate1 \ --method org.freedesktop.timedate1.SetNTP true false The problem is that the org.freedesktop.timedate1.SetNTP method appears to *enable* the ntpd.service and then start it. This should not be done, since in a NetworkManager scenario, the ntpd.service should be left disabled and only *started* when a connection is made. The result of this bug is that upon a reboot, ntpd.service is automatically started, BEFORE network manager creates a connection. Even after ntpd.service is disabled again, the next time a connection is made, ntpd.service is re-enabled. I believe this is the problem: http://cgit.freedesktop.org/systemd/systemd/tree/src/timedate/timedated.c Line 871: r = enable_ntp(connection, &error); I think that should be removed, so that only the remaining start_ntp() call is made.