Bug 56218

Created attachment 68830 [details] [review]
0001-Show-all-suppressed-introspection-scanner-warnings.patch

Created attachment 68831 [details] [review]
0002-Include-Gio-2.0-for-introspection.patch

I am not sure this is the right thing to do, I do not have much understanding of introspection.

Created attachment 68833 [details] [review]
0003-Exclude-poppler-input-stream.h-from-introspection-fi.patch

poppler-input-stream.h seems to be a private header file. Therefor, as far as I understand it, it should not be included in introspection_files.

Carlos or anyone with glib experience, could you guys have a look at this one?

Comment on attachment 68831 [details] [review]
0002-Include-Gio-2.0-for-introspection.patch

Review of attachment 68831 [details] [review]:
-----------------------------------------------------------------

This look goods to me. Not only resolves the warnings, but also makes poppler_document_new_from_stream" and poppler_document_new_from_gfile introspectable.

Comment on attachment 68833 [details] [review]
0003-Exclude-poppler-input-stream.h-from-introspection-fi.patch

Review of attachment 68833 [details] [review]:
-----------------------------------------------------------------

This does not hurt, as poppler-input-stream is private... but the fact that this warning appears might be a bug in the gir-scanner as the inputStreamBufSize is inside a #ifndef __GI_SCANNER__

Created attachment 70288 [details] [review]
Patch to fix yet another warnings

while reviewing/testing hib's patches, I discover some small typos in the documentation of some functions they were mising the : at the end. This patches fixes that and supress the warnings that I get with the gir-scanner in my machine. The gir file does not change with this patch

Comment on attachment 68830 [details] [review]
0001-Show-all-suppressed-introspection-scanner-warnings.patch

Review of attachment 68830 [details] [review]:
-----------------------------------------------------------------

With other Hib patches and my last patch, we should not get any warnings anymore, so enabling the warnings to keep the sanity seems a good idea to me.

Carlos? Commit?

(In reply to comment #5)
> Comment on attachment 68831 [details] [review] [review]
> 0002-Include-Gio-2.0-for-introspection.patch
> 
> Review of attachment 68831 [details] [review] [review]:
> -----------------------------------------------------------------
> 
> This look goods to me. Not only resolves the warnings, but also makes
> poppler_document_new_from_stream" and poppler_document_new_from_gfile
> introspectable.

Right, now I am thinking, shouldn't we also change the version number in the gir file? I am not sure what the 0.18 in Poppler-0.18.gir is supposed to reflect.

Hey guys, I'm sorry, I had this bug lost in my inbox and I had forgotten it. I've just pushed all the patches. Thanks!