| Summary: | gcc throws too many warnings with libfprint git master | ||
|---|---|---|---|
| Product: | libfprint | Reporter: | Vasily Khoruzhick <anarsoul> |
| Component: | libfprint | Assignee: | libfprint-bugs |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | medium | CC: | anarsoul |
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: |
0001-AES1610-driver-cleanup.patch
0002-UPEKE2-driver-cleanup.patch 0003-UPEKSONLY-driver-cleanup.patch 0004-nbis-prefix-global-variables-with-g_.patch 0005-nbis-fix-rest-of-warnings-reported-by-gcc.patch 0006-lib-fix-warning-in-syn~ted-by-gcc-when-debug.patch 0001-AES1610-driver-cleanup-part-1.patch 0002-AES1610-driver-cleanup-part-2.patch |
||
|
Description
Vasily Khoruzhick
2012-10-26 18:28:37 UTC
Created attachment 69126 [details] [review] 0001-AES1610-driver-cleanup.patch Created attachment 69127 [details] [review] 0002-UPEKE2-driver-cleanup.patch Created attachment 69128 [details] [review] 0003-UPEKSONLY-driver-cleanup.patch Created attachment 69129 [details] [review] 0004-nbis-prefix-global-variables-with-g_.patch Created attachment 69130 [details] [review] 0005-nbis-fix-rest-of-warnings-reported-by-gcc.patch Created attachment 69131 [details] [review] 0006-lib-fix-warning-in-syn~ted-by-gcc-when-debug.patch Bastien, ping? Comment on attachment 69126 [details] [review] 0001-AES1610-driver-cleanup.patch Review of attachment 69126 [details] [review]: ----------------------------------------------------------------- Can you split the code removal, and the warning fixes please? Comment on attachment 69127 [details] [review] 0002-UPEKE2-driver-cleanup.patch Review of attachment 69127 [details] [review]: ----------------------------------------------------------------- Looks good. Comment on attachment 69128 [details] [review] 0003-UPEKSONLY-driver-cleanup.patch Review of attachment 69128 [details] [review]: ----------------------------------------------------------------- Looks good. Comment on attachment 69129 [details] [review] 0004-nbis-prefix-global-variables-with-g_.patch Review of attachment 69129 [details] [review]: ----------------------------------------------------------------- This sounds like it would make NBIS harder to update. I'd love to get this code copy/pastable from the upstream (that I don't know where it lives). (In reply to comment #8) > Comment on attachment 69126 [details] [review] [review] > 0001-AES1610-driver-cleanup.patch > > Review of attachment 69126 [details] [review] [review]: > ----------------------------------------------------------------- > > Can you split the code removal, and the warning fixes please? Sure Comment on attachment 69130 [details] [review] 0005-nbis-fix-rest-of-warnings-reported-by-gcc.patch Review of attachment 69130 [details] [review]: ----------------------------------------------------------------- Do we have an upstream for those? Comment on attachment 69131 [details] [review] 0006-lib-fix-warning-in-syn~ted-by-gcc-when-debug.patch Review of attachment 69131 [details] [review]: ----------------------------------------------------------------- Looks good. (In reply to comment #11) > Comment on attachment 69129 [details] [review] [review] > 0004-nbis-prefix-global-variables-with-g_.patch > > Review of attachment 69129 [details] [review] [review]: > ----------------------------------------------------------------- > > This sounds like it would make NBIS harder to update. > I'd love to get this code copy/pastable from the upstream (that I don't know > where it lives). Daniel Drake already did some cleanup and rework (see git log libfprint/nbis) Anyway I'm not sure if this code gets any updates at all. Created attachment 69582 [details] [review] 0001-AES1610-driver-cleanup-part-1.patch Created attachment 69583 [details] [review] 0002-AES1610-driver-cleanup-part-2.patch Comment on attachment 69582 [details] [review] 0001-AES1610-driver-cleanup-part-1.patch Review of attachment 69582 [details] [review]: ----------------------------------------------------------------- Looks good. Comment on attachment 69583 [details] [review] 0002-AES1610-driver-cleanup-part-2.patch Review of attachment 69583 [details] [review]: ----------------------------------------------------------------- ++ commit 6b84c6664fe9da98e013caab99145d8f0279b9bb Author: Vasily Khoruzhick <anarsoul@gmail.com> Date: Mon Nov 5 22:39:49 2012 +0300 AES1610: driver cleanup, part #2 Remove dead code https://bugs.freedesktop.org/show_bug.cgi?id=56439 commit f569d0bf4479c4d6ebf1972b59cd7450ec9a3258 Author: Vasily Khoruzhick <anarsoul@gmail.com> Date: Sat Oct 20 12:26:38 2012 +0300 AES1610: driver cleanup, part #1 Fix warnings reported by gcc https://bugs.freedesktop.org/show_bug.cgi?id=56439 commit 1cfd14b7fe8f9e68c5bd74461bcd17e25b9f1d15 Author: Vasily Khoruzhick <anarsoul@gmail.com> Date: Fri Oct 26 16:40:53 2012 +0300 nbis: fix rest of warnings reported by gcc https://bugs.freedesktop.org/show_bug.cgi?id=56439 commit 5d32102efefe955e9f5bdbf5809a5fb637d77e89 Author: Vasily Khoruzhick <anarsoul@gmail.com> Date: Fri Oct 26 16:36:21 2012 +0300 nbis: prefix global variables with "g_" It fixes a lot of warnings about shadowing global variable https://bugs.freedesktop.org/show_bug.cgi?id=56439 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.