Bug 56685

Please try this patch:
http://lists.freedesktop.org/archives/mesa-dev/2012-November/029511.html

Still same error with the patch:
  CXX    glsl_lexer.o
glsl_lexer.ll:29:25: fatal error: glsl_parser.h: No such file or directory
compilation terminated.

https://launchpadlibrarian.net/121932664/buildlog_ubuntu-quantal-i386.mesa_9.1~git1211031452.84b437~gd~q_FAILEDTOBUILD.txt.gz

Created attachment 69491 [details] [review]
Possible fix

Please try this patch.

> Created attachment 69491 [details] [review] [review]
> Please try this patch.

I am still getting the same error:
https://launchpadlibrarian.net/122265792/buildlog_ubuntu-quantal-i386.mesa_9.1~git1211071345.65faed~gd~q_FAILEDTOBUILD.txt.gz

Created attachment 69667 [details] [review]
Possible Fix

Next try ...

Thierry, I think your cross compiling patch caused this -- broken out of tree builds.

Comment on attachment 69667 [details] [review]
Possible Fix

Review of attachment 69667 [details] [review]:
-----------------------------------------------------------------

I came up with a very similar, though simpler patch that I've successfully
tested on top of latest master, both in-tree and out-of-tree as well as
parallel and non-parallel builds.

With the below comments applied, Johannes' patch becomes effectively the
same as mine.

::: src/glsl/builtin_compiler/Makefile.am
@@ +29,4 @@
>  LD = @LD_FOR_BUILD@
>  LDFLAGS = @LDFLAGS_FOR_BUILD@
>  
> +include ../Makefile.sources

You don't need to move the Makefile.sources include
because GLSL_SRCDIR, GLSL_BUILDDIR and AM_CFLAGS
are all lazily evaluated.

Don't forget to remove the corresponding comment in
the commit message.

@@ +36,5 @@
>  	-I $(top_srcdir)/src/mapi \
>  	-I $(top_srcdir)/src/mesa \
>  	-I $(GLSL_SRCDIR) \
>  	-I $(GLSL_SRCDIR)/glcpp \
> +	-I $(GLSL_BUILDDIR) \

Can we please sort this above GLSL_SRCDIR so that
files in GLSL_BUILDDIR will take precedence?

(In reply to comment #6)
> Thierry, I think your cross compiling patch caused this -- broken out of
> tree builds.

I suppose that had to happen to me, usually being very allergic to broken
out-of-tree builds. Maybe Mesa hasn't supported out-of-tree builds for so
long it didn't occur to me that it may have changed. Needless to say I'm
very happy that it works now.

Thanks a bunch for putting all this work into it Matt (and everyone else
who helped)!

(In reply to comment #5)
> Created attachment 69667 [details] [review] [review]
> Possible Fix
> 
> Next try ...

With this I can successfully compile mesa.

I pushed a patch from bug 56787, since it fixed the problem the right way.

*** This bug has been marked as a duplicate of bug 56787 ***

(In reply to comment #10)
> I pushed a patch from bug 56787, since it fixed the problem the right way.
> 
> *** This bug has been marked as a duplicate of bug 56787 ***

As I've said in my review of the patch in this bug, the GLSL_BUILDDIR should
be moved before the GLSL_SRCDIR in the include path to make sure the generated
files take precedence.

How could glsl_parser.h exist in both src and build directories?

(In reply to comment #12)
> How could glsl_parser.h exist in both src and build directories?

There could be any number of reasons. The most likely would be if somebody's
built in-tree, so glsl_parser.h gets generated in the source tree, and then
decides to build out-of-tree. Granted, a proper build system would detect and
prevent that, but I'm not sure we're there yet.

There's also always the possibility of somebody just copying it there.

But my point was that it usually is a sensible decision to prefer the contents
of the build tree over those of the source tree. I've seen lots of packages
that were broken in some subtle way and would specifically generate files in
the build tree, but then go and reuse the one that shipped in the source tree.

Such bugs can be very hard to find and they usually aren't obvious from the
start, so if there's an easy way to avoid them I think we should do so.