Bug 56809

The fields are not ordered, so the order in which they appear has no importance.
Why are you opening this bug? what problem are you seeing? is there an actual behavioral bug? does it affect the user? or is this just a comment on something you noticed?

The problem is that users using the latest version of Windows Live Messenger do not see the typing notification being sent by emesene.

The latest revision of aMSN sends ordered fields and users of the latest Windows Live Messenger report seeing typing notifications with it. If you believe the issue is not related to the order of the fields I can investigate further.

Ok thanks, it's possible the new version uses a more strict parsing rule. Will need to patch it then in order to order the fields.

could it be there's an extra \r\n?

2012/11/6  <bugzilla-daemon@freedesktop.org>:
> Comment # 3 on bug 56809 from Dario
>
> The latest revision of aMSN sends ordered fields and users of the latest
> Windows Live Messenger report seeing typing notifications with it. If you
> believe the issue is not related to the order of the fields I can
> investigate
> further.
>
> ________________________________
> You are receiving this mail because:
>
> You are the assignee for the bug.
>
>
> _______________________________________________
> papyon-bugs mailing list
> papyon-bugs@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/papyon-bugs
>

Yes, there is an extra \r\n. I thought it was due to the weird ordering. Though there is no need for the fields to be ordered in a specific way I think it would be better to stick with the official protocol: http://www.hypothetic.org/docs/msn/client/messages.php.

You can try tweaking emesene/e3/papylib/papyon/papyon/conversation.py:


    def send_typing_notification(self):
        content_type = "text/x-msmsgscontrol"
        body = "\r\n\r\n".encode('UTF-8')
        headers = { "TypingUser" : self._client.profile.account }
        self._send_message_ex(content_type, body, headers)


2012/11/6  <bugzilla-daemon@freedesktop.org>:
> Comment # 6 on bug 56809 from Dario
>
> Yes, there is an extra \r\n. I thought it was due to the weird ordering.
> Though
> there is no need for the fields to be ordered in a specific way I think it
> would be better to stick with the official protocol:
> http://www.hypothetic.org/docs/msn/client/messages.php.
>
> ________________________________
> You are receiving this mail because:
>
> You are the assignee for the bug.
>
>
> _______________________________________________
> papyon-bugs mailing list
> papyon-bugs@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/papyon-bugs
>

Removing the extra \r\n does not fix the issue. I had already found send_typing_notification - I didn't write a patch for it myself because I had correctly suspected that a more global fix is needed to properly order the fields for every type of packet sent.

Fixing the order field in a global way may prevent more problems to surface as later versions of the protocol are released.

Created attachment 71418 [details] [review]
Patch for /papyon/conversation.py to fix the typing notification problem

This patch fixes the typing notification bug. The MIME-Version field is still appended at the bottom of the MIME packet though.

Feel free to apply the patch upstream and set the status as RESOLVED.