| Summary: | [regression] Weston event-test unit test failure | ||
|---|---|---|---|
| Product: | Wayland | Reporter: | U. Artie Eoff <ullysses.a.eoff> |
| Component: | weston | Assignee: | Wayland bug list <wayland-bugs> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | medium | ||
| Version: | unspecified | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | event test failure | ||
I did some reseach on this and it seems to be three issues that needs to be fixed. The first is that the test-client does not commit after creating a surface, meaning it will never actually be commited to the server. The second issue is that the input region of the surface is not updated when the event-test resizes. This can be fixed by adding a weston_surface_update_input_area called afer resizing that re-reads the pending input region and intersects the changed geometry with the pending to create a new updated input region. The third issue is that there was nothing making sure that all pending events (input events etc) were handled before the test-client replied to a send-state. Strategically adding roundtrips in the client seems to solve that. Hi Jonas, Were you looking at cooking up patches based on your discoveries below? commit 1ba9b38ec6ff0d9a8661cc6f98eab34cbf6efd1e Author: U. Artie Eoff <ullysses.a.eoff@intel.com> Date: Fri Dec 7 13:50:32 2012 -0800 tests: Convert keyboard-test to new test extension This adds a weston-test-runner for the weston test extension and some weston test client helper methods. Converted keyboard-test to use the new test interface, runner, and helper methods. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=56822 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com> Oops, this is the commit that fixes the problem: commit 84f9db5f9013803e1bfac22363f4287af6bf42e7 Author: U. Artie Eoff <ullysses.a.eoff@intel.com> Date: Fri Dec 7 13:50:33 2012 -0800 tests: Convert event-test to new test extension Fixes https://bugs.freedesktop.org/show_bug.cgi?id=56819 Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 69641 [details] event test failure Weston event-test has been failing since 0.99.0 release. cairo (master) 6ed1da67b5814c5ff062831f17621a585f81d704 dri2proto (master) 4eeacce4c4a300b938b7e3fb78a8e443c491780b drm (master) e01d68f9f3acfc35fe164283904b5d058c2ab378 kbproto (master) 391a1f6de6315fc0196d407d800597488315cccb libX11 (master) d14b6a250f004fa405179db7020f6953001d17b9 libxkbcommon (master) 998c957a3c7c861093f3f71f34989c258ed3073b macros (master) 0890e4003aacfa7113ab3f4e3ad7c5636f8e922a mesa (master) 0d61f879a1f2e6bb37368731a29d5267e1c25195 pixman (master) 4b91f6ca72db3e8cbd7e97e9ef44be2f8994040d wayland (master) 1801cdc41ac0653e4ff0f0cc4eeaf373ae40edf4 weston (master) 0f7a285fe187aea405dc5e6f6268a79bdf9d1627 LKG is weston 4e07236e87, wayland 0371668dcc, and mesa 0ce21660c2