Bug 56889

Summary:	pixman-ppc.c:40: error: 'have_vmx' undeclared (first use in this function)
Product:	pixman	Reporter:	Ryan Schmidt <freedesktop>
Component:	pixman	Assignee:	Søren Sandmann Pedersen <soren.sandmann>
Status:	RESOLVED FIXED	QA Contact:	Søren Sandmann Pedersen <soren.sandmann>
Severity:	normal
Priority:	medium
Version:	0.28.x
Hardware:	PowerPC
OS:	Mac OS X (All)
Whiteboard:
i915 platform:		i915 features:

Description Ryan Schmidt 2012-11-08 19:42:22 UTC

Building pixman 0.28.0 fails on PowerPC Mac OS X with this error:

pixman-ppc.c:40: error: 'have_vmx' undeclared (first use in this function)

This was reported to the MacPorts project here:

https://trac.macports.org/ticket/36923

There you may see a full build log if desired.

Here is the patch we are using to fix this:

https://trac.macports.org/attachment/ticket/36923/pixman_pixman-ppc.c.patch

This fixes the "#ifdef __APPLE__" case, but we believe the "#elif defined (__OpenBSD__)" case has a similar problem (trying to check "sizeof(have_vmx)" before having declared that variable).

P.S: Version 0.28.x is missing from the Version menu in this issue tracker.

Comment 1 Søren Sandmann Pedersen 2012-11-08 21:14:11 UTC

Thanks for the bug report.

The patch looks good to me (it appears to also solve the OpenBSD issue). If you send it to the list (pixman@lists.freedesktop.org) with a git changelog, I'll apply it.

> P.S: Version 0.28.x is missing from the Version menu in this issue tracker.

Fixed, thanks.

Comment 2 Ryan Schmidt 2012-11-13 04:49:17 UTC

(In reply to comment #1)
> The patch looks good to me (it appears to also solve the OpenBSD issue). If
> you send it to the list (pixman@lists.freedesktop.org) with a git changelog,
> I'll apply it.

Joshua sent it to the list:

http://lists.freedesktop.org/archives/pixman/2012-November/002331.html

Comment 3 Søren Sandmann Pedersen 2012-11-14 00:35:03 UTC

Pushed to master - thanks.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.