Bug 57129

Summary:	[regression] Compilation fails for weston unit tests
Product:	Wayland	Reporter:	U. Artie Eoff <ullysses.a.eoff>
Component:	weston	Assignee:	Wayland bug list <wayland-bugs>
Status:	VERIFIED FIXED	QA Contact:
Severity:	critical
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description U. Artie Eoff 2012-11-14 19:38:26 UTC

First bad commit: http://cgit.freedesktop.org/wayland/weston/commit/?id=320711db0a2e7ce11664198cefc6c3182f8ca273

The weston unit tests fail to compile using 'make check' with the following error:

surface-global-test.c: In function 'surface_to_from_global':
surface-global-test.c:30:2: error: unknown type name 'GLfloat'
surface-global-test.c:38:2: warning: passing argument 4 of 'weston_surface_to_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:486:1: note: expected 'float *' but argument is of type 'int *'
surface-global-test.c:38:2: warning: passing argument 5 of 'weston_surface_to_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:486:1: note: expected 'float *' but argument is of type 'int *'
surface-global-test.c:41:2: warning: passing argument 4 of 'weston_surface_to_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:486:1: note: expected 'float *' but argument is of type 'int *'
surface-global-test.c:41:2: warning: passing argument 5 of 'weston_surface_to_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:486:1: note: expected 'float *' but argument is of type 'int *'
surface-global-test.c:48:2: warning: passing argument 4 of 'weston_surface_from_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:490:1: note: expected 'float *' but argument is of type 'int *'
surface-global-test.c:48:2: warning: passing argument 5 of 'weston_surface_from_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:490:1: note: expected 'float *' but argument is of type 'int *'
surface-global-test.c:51:2: warning: passing argument 4 of 'weston_surface_from_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:490:1: note: expected 'float *' but argument is of type 'int *'
surface-global-test.c:51:2: warning: passing argument 5 of 'weston_surface_from_global_float' from incompatible pointer type [enabled by default]
In file included from test-runner.h:1:0,
from surface-global-test.c:24:
../src/compositor.h:490:1: note: expected 'float *' but argument is of type 'int *'
Exception: Error status 1 from /usr/lib64/ccache/gcc
make[2]: *** [surface-global-test.lo] Error 1
make[2]: Leaving directory `/home/uartie/Work/intel/wayland/build/weston/tests'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/home/uartie/Work/intel/wayland/build/weston/tests'
make: *** [check-recursive] Error 1
warn: "make -e check" failed - exitcode 2

Comment 1 Kristian Høgsberg 2012-11-14 19:41:53 UTC

commit f3dfe716f34d8d3a1b9a6673f41f8884aab55ea1
Author: Kristian Høgsberg <krh@bitplanet.net>
Date:   Wed Nov 14 14:42:51 2012 -0500

    tests: Remove last GLfloat use
    
    With the EGL/GLES2 types out of compositor.h this now fails to compile.
    
    https://bugs.freedesktop.org/show_bug.cgi?id=57129

Comment 2 U. Artie Eoff 2012-11-14 19:47:22 UTC

verified. thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.