Bug 57327

Summary:	[intel-driver] Build broken when CFLAGS=-g3
Product:	libva	Reporter:	Joe Konno <joe.konno>
Component:	intel	Assignee:	haihao <haihao.xiang>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	brian.j.lovin, gb.devel, rob, ullysses.a.eoff
Version:	unspecified
Hardware:	Other
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	0001-configure.ac-Ensure-libm-is-linked.patch

Description Joe Konno 2012-11-20 15:51:52 UTC

The intel-driver code breaks when running the autogen.sh (autoconf and friends) script. Specifically, when the shell has CFLAGS=-g3. Compilation would fail due to unresolved cos() and sin() symbols. This was not seen in a default "release" compile, though. Manually adding "-lm" to Makefile fixed the issue.

I am attaching a non-controversial fix to the configure.ac that appears to resolve the issue.

"intel-driver code" refers to the following repository:
http://cgit.freedesktop.org/vaapi/intel-driver/

And patch is based off:
http://cgit.freedesktop.org/vaapi/intel-driver/commit/?id=63db874e9c924f086bcd3518cc0f3d8c6df9ecec

Comment 1 Joe Konno 2012-11-20 15:54:07 UTC

Created attachment 70320 [details] [review]
0001-configure.ac-Ensure-libm-is-linked.patch

Addition of a simple autoconf directive

Comment 2 Joe Konno 2012-11-20 15:54:52 UTC

gb, rob, mind reviewing this issue and patch?

Comment 3 Gwenole Beauchesne 2012-11-20 17:05:23 UTC

Hi Joe, yes, this patch is needed since the VEBOX additions. In particular, gen75_vpp_vebox.c is using the sin() function. I will apply your patch with s/cos/sin/ -- not that it changes anything, but at least it points to what we actually use. Thanks.

Comment 4 Gwenole Beauchesne 2012-11-20 17:31:05 UTC

Pushed to git master and staging branches.

Comment 5 Joe Konno 2012-11-20 17:41:27 UTC

Resolved Fix-- Brian, could I trouble you for a "verify?"

Comment 6 Joe Konno 2012-11-29 14:49:39 UTC

Verified.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.