Bug 57338

Created attachment 73722 [details] [review]
Handle MESA_FORMAT_RGBA_16 in _mesa_format_matches_format_and_type().

The profile in the winehq bug does look somewhat similar to the one for bug 55396. Does this patch make it any better?

Created attachment 73723 [details]
sysprof

I have the same like without patches. Anything better.

Also I added sysprof from wine bugzilla to make it more clear.

That was just the patch you attached, not the sysprof.

Created attachment 74273 [details]
sysprof

My mistake, sorry.

That's short messages, so I'm not adding attachments.

After this debug patch:

diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c
index 7299a4b..679646d 100644
--- a/src/mesa/main/texgetimage.c
+++ b/src/mesa/main/texgetimage.c
@@ -664,6 +664,8 @@ _mesa_get_teximage(struct gl_context *ctx,
       get_tex_ycbcr(ctx, dimensions, format, type, pixels, texImage);
    }
    else {
+      fprintf(stderr, "Using slow texture readback for format %#x, type %#x, and internal format %#x.\n",
+            format, type, texImage->TexFormat);
       get_tex_rgba(ctx, dimensions, format, type, pixels, texImage);
    }



I got this messages in Star Wars JK Jedi Academy MP intro:

Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x4a.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x4c.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x3e.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x4a.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x4c.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x3e.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x7.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x30.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0xb.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x10.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x10.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0xb.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x18.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0xb.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x26.
Using slow texture readback for format 0x80e1, type 0x8367, and internal format 0x7.

Wine shows logs under terminal:

err:ole:CoInitializeEx Attempt to change threading model of this apartment from multi-threaded to apartment threaded
fixme:d3d:check_fbo_compat Format WINED3DFMT_R16G16_UNORM with rendertarget flag is not supported as FBO color attachment, and no fallback specified.
fixme:d3d:check_fbo_compat Format WINED3DFMT_R16G16B16A16_UNORM with rendertarget flag is not supported as FBO color attachment, and no fallback specified.
fixme:win:EnumDisplayDevicesW ((null),0,0x32e958,0x00000000), stub!
err:seh:raise_exception Exception frame is not in stack limits => unable to dispatch exception.


Where I noticed lines:

fixme:d3d:check_fbo_compat Format WINED3DFMT_R16G16_UNORM with rendertarget flag is not supported as FBO color attachment, and no fallback specified.
fixme:d3d:check_fbo_compat Format WINED3DFMT_R16G16B16A16_UNORM with rendertarget flag is not supported as FBO color attachment, and no fallback specified.

I don't see this lines using old mesa 7.11 (where everything is OK). Maybe there is a problem?

Same note about INTEL_DEBUG=perf environment variable here.

Dear Reporter,

This Mesa bug has been in the "NEEDINFO" status for over 60 days. I am closing this bug based on lack of response but feel free to reopen if resolution is still needed. Please ensure you're supplying the correct information as requested.

Thank you.