Bug 57386

Summary: Cannot configure when cross-compiling
Product: xorg Reporter: Ross Burton <ross>
Component: Driver/omapAssignee: Rob Clark <robclark>
Status: RESOLVED FIXED QA Contact: Xorg Project Team <xorg-team>
Severity: normal    
Priority: medium CC: kulya.xtp
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
Patch none

Description Ross Burton 2012-11-21 23:06:17 UTC
xf86-video-omap/configure.ac uses AC_CHECK_FILE, which when cross-compiling always returns an error.

It appears to be used solely to detect if the DRI headers are available.  Can't it just use PKG_CHECK_EXISTS(drm, ...) instead?
Comment 1 Ross Burton 2012-11-21 23:41:39 UTC
Created attachment 70396 [details] [review]
Patch

I've never seen this module before, and can't test as I don't have libdrm_omap to hand, but this looks like the right thing to do!
Comment 2 Rob Clark 2012-11-26 19:44:29 UTC
yeah, there is no DRI1 support (only DRI2), so I believe the correct thing is to get rid of all that stuff from configure.ac.  I suspect you can also get rid of xf86driproto and glproto dependencies as well.
Comment 3 Rob Clark 2012-11-27 00:08:16 UTC
fyi, I've pushed a commit to remove the DRI1 dependency in configure.ac

Let me know if there are any further issues or if it is ok to close this bug.  Thanks!
Comment 4 Ross Burton 2012-12-05 15:39:51 UTC
You applied 99% of my patch, so I'll close this.

(fwiw, credit would have been nice)
Comment 5 Rob Clark 2012-12-05 19:25:44 UTC
oh, sorry, forgot about that when I was pushing the patch

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.