|
Description
Vasily Khoruzhick
2012-11-22 19:29:09 UTC
Created attachment 70448 [details] [review] 0001-Thanks-to-Greg-and-Martin-from-AuthenTec.patch Created attachment 70449 [details] [review] 0002-aes-unify-image-processing-code-for-AuthenTec-device.patch Created attachment 70450 [details] [review] 0003-aeslib-prevent-integer-overflow.patch Created attachment 70451 [details] [review] 0004-Split-fpi_im_resize-factor-argument-into-width_facto.patch Created attachment 70452 [details] [review] 0005-lib-add-AES1660-driver.patch Created attachment 70462 [details] [review] 0006-Add-a-workaround-for-bug-in-MINDTCT.patch It's RFC patch, I don't insist on merging it right now, however it fixes crash for me on AES1660, AES2501 and AES2550. Created attachment 70546 [details] [review] 0001-Thanks-to-Greg-and-Martin-from-AuthenTec.patch Created attachment 70547 [details] [review] 0002-aes-unify-image-processing-code-for-AuthenTec-device.patch Created attachment 70548 [details] [review] 0003-aeslib-prevent-integer-overflow.patch Created attachment 70549 [details] [review] 0004-Split-fpi_im_resize-factor-argument-into-width_facto.patch Created attachment 70550 [details] [review] 0005-lib-add-AES1660-AES2660-common-routines.patch Created attachment 70551 [details] [review] 0006-lib-add-AES1660-driver.patch Created attachment 70552 [details] [review] 0007-lib-add-AES2660-driver.patch Created attachment 70553 [details] [review] 0008-Add-a-workaround-for-bug-in-MINDTCT.patch Created attachment 70554 [details] [review] 0009-Update-AUTHORS-file.patch Now this series also contains AES2660 driver. It's quite similar to AES1660, and they share almost all code, the only difference is in init commands and start imaging commands, and in sensor size (AES1660 is 128x8, AES2660 is 192x8). Comment on attachment 70547 [details] [review] 0002-aes-unify-image-processing-code-for-AuthenTec-device.patch Review of attachment 70547 [details] [review]: ----------------------------------------------------------------- Use g_slist_free_full() instead of two separate calls. Comment on attachment 70553 [details] [review] 0008-Add-a-workaround-for-bug-in-MINDTCT.patch Review of attachment 70553 [details] [review]: ----------------------------------------------------------------- Pretty sure I mentioned I didn't like that change. All committed except patch 8. (In reply to comment #19) > All committed except patch 8. OK for me, it was RFC patch |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.