Summary: | glib/demo is not compiled with warnings enabled | ||
---|---|---|---|
Product: | poppler | Reporter: | Hib Eris <hib> |
Component: | glib frontend | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
0001-Enable-compiler-warnings-for-C-code.patch
0002-Fix-warnings-on-unused-variables.patch 0003-Fix-warning-on-unused-variable-selection.patch 0004-Do-not-use-text-uninitialized.patch 0005-Remove-unused-variable-region.patch 0006-Remove-unused-variable-slice_selector.patch 0007-Fix-warning-operation-on-page-may-be-undefined-Wsequ.patch 0008-Remove-set-but-unused-variable-textinfo.patch 0009-pgd_text_view_query_tooltip-return-a-gboolean.patch 0010-Fix-set-but-unused-warning-in-glib-demo.patch 0011-Fix-warning-on-signedness-in-glib-demo.patch |
Created attachment 70675 [details]
0002-Fix-warnings-on-unused-variables.patch
Created attachment 70676 [details] [review] 0003-Fix-warning-on-unused-variable-selection.patch Created attachment 70677 [details] [review] 0004-Do-not-use-text-uninitialized.patch Created attachment 70678 [details] [review] 0005-Remove-unused-variable-region.patch Created attachment 70679 [details] [review] 0006-Remove-unused-variable-slice_selector.patch Created attachment 70680 [details] [review] 0007-Fix-warning-operation-on-page-may-be-undefined-Wsequ.patch Created attachment 70681 [details] [review] 0008-Remove-set-but-unused-variable-textinfo.patch Created attachment 70682 [details] [review] 0009-pgd_text_view_query_tooltip-return-a-gboolean.patch Created attachment 70683 [details] [review] 0010-Fix-set-but-unused-warning-in-glib-demo.patch Created attachment 70691 [details] [review] 0011-Fix-warning-on-signedness-in-glib-demo.patch Pushed all the patches, thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 70674 [details] 0001-Enable-compiler-warnings-for-C-code.patch By default, poppler compiles with compiler warnings enabled for the C++ compiler, by settings CXXFLAGS appropriatly. However, glib/demo use a C compiler. For that, one shoul set CFLAGS accordingly.