Bug 57881

Assign to me, this was introduced with my fa0f42bafbf24e9141ddee728b160b5ab47077f2.

Created attachment 71792 [details]
patch

The constants in sw/inc/pagedesc.hxx (namespace nsUseOnPage) were changed (PD_FIRST added, others changed) and are different from svx/inc/svx/pageitem.hxx (enum SvxPageUsage). 
SvxPageUsage is used in the page format dialog with parameters choosen from nsUseOnPage...
Patch changes namespace nsUseOnPage back to the values from SvxPageUsage and removes PD_FIRST. The changes in GetFirstFmt() are necessary for separate headers and/or footers on the first page (PD_FIRST is never set in the old code).

Hi Werner,

Sounds great, thanks for your patch! I'll give it a bit more testing -- in the meantime, could you send a license statement to libreoffice@lists.freedesktop.org, please? Just a normal mail with a body of

"All of my past & future contributions to LibreOffice may be licensed 
under the MPL/LGPLv3+ dual license"

That is necessary before I push your patch.

Thanks,

Miklos

Hi Miklos,

i sent a license statement http://lists.freedesktop.org/archives/libreoffice/2012-December/042823.html.

Werner

Created attachment 71804 [details]
patch

This small bug is the cause for the selection of page style 'mirrored' as default for undef. page style instead of 'right and left'.

(In reply to comment #2)
> Created attachment 71792 [details]
> patch
> 
> The constants in sw/inc/pagedesc.hxx (namespace nsUseOnPage) were changed
> (PD_FIRST added, others changed) and are different from
> svx/inc/svx/pageitem.hxx (enum SvxPageUsage). 
> SvxPageUsage is used in the page format dialog with parameters choosen from
> nsUseOnPage...
> Patch changes namespace nsUseOnPage back to the values from SvxPageUsage and
> removes PD_FIRST. The changes in GetFirstFmt() are necessary for separate
> headers and/or footers on the first page (PD_FIRST is never set in the old
> code).

Sadly this breaks the test described at https://bugs.freedesktop.org/show_bug.cgi?id=58376#c14.

Miklos Vajna committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bee957fc48867aa1b98b8672b02a187a461f4e38

fdo#57881 sw: make UseOnPage independent from SvxPageUsage



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Miklos Vajna committed a patch related to this issue.
It has been pushed to "libreoffice-4-0":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5c3450498b7f818fcff70d8daf1aa0d25f60c663&g=libreoffice-4-0

fdo#57881 sw: make UseOnPage independent from SvxPageUsage


It will be available in LibreOffice 4.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

Fixed in master and -4-0, marking as resolved.

Hi Werner,

So finally I didn't take your patch, but still added your license statement to https://wiki.documentfoundation.org/Development/Developers#First_name_from_G_to_N, so next time you send a patch, you no longer have to care about those details. :)

Thanks,

Miklos