| Summary: | Compile tests on `make check` invocation | ||
|---|---|---|---|
| Product: | cairo | Reporter: | Marvin Schmidt <marvin_schmidt> |
| Component: | general | Assignee: | Chris Wilson <chris> |
| Status: | RESOLVED MOVED | QA Contact: | cairo-bugs mailing list <cairo-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | dstrokis |
| Version: | 1.12.8 | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | use check_PROGRAMS to compile tests on make check | ||
I was wondering about the "always build" comment on that line. It comes from the following commit: commit b8f43617a98aeb6c10d554ed11b48a83fc9b5129 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Sat Jul 16 20:45:03 2011 +0100 test: Always compile cairo-test-suite I'm tired of having to explicitly type make cairo-test-suite. I know that "make check" will compile this after your patch, but thanks to newer automakes hiding test's output, I think that running the test suite through "make check" is quite useless. In other words, the proposed patch effictively reverts the above commit and thus I don't think it is likely that this will get merged (just my 5c). -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/cairo/cairo/issues/70. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 71511 [details] use check_PROGRAMS to compile tests on make check Currently tests are treated like normal programs and are therefore built during `make`. This requires having all test dependencies installed to succeed. Among the test dependencies are packages which depend on cairo itself, causing a circular dependency. To work around this one could compile cairo first without running tests, compile all test dependencies and then get back to running the tests. This can easily be made possible by using "check_PROGRAMS" for the tests instead of "noinst_PROGRAMS", resulting in the tests getting built when `make check` is invoked The attached patch does just that