Bug 58326

Summary: [llvmpipe] piglit glean depthStencil regression
Product: Mesa Reporter: Vinson Lee <vlee>
Component: OtherAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: maraeo
Version: git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:

Description Vinson Lee 2012-12-15 08:57:12 UTC 
mesa: 7d7a549fa03293ede1d1627be5bdb47c11677f87 (master)

Run piglit glean depthStencil.

The test previously passed but now results in a warning with the message "cannot blit stencil, skipping".

$ ./bin/glean -r results -t depthStencil --quick
Mesa: User error: GL_INVALID_ENUM in glDrawPixels(invalid format GL_DEPTH_STENCIL and/or type GL_UNSIGNED_INT)
Mesa: User error: GL_INVALID_OPERATION in glDrawPixels(invalid format GL_DEPTH_COMPONENT and/or type GL_UNSIGNED_INT_24_8)
Mesa: User error: GL_INVALID_ENUM in glReadPixels(invalid format GL_DEPTH_STENCIL and/or type GL_FLOAT)
Mesa: User error: GL_INVALID_OPERATION in glReadPixels(invalid format GL_STENCIL_INDEX and/or type GL_UNSIGNED_INT_24_8)
llvmpipe: cannot blit stencil, skipping
llvmpipe: cannot blit stencil, skipping
depthStencil:  PASS rgba8, db, z24, s8, accrgba16, win+pmap, id 33

976b832e9ae199c0a89b0e04e93088da3c829307 is the first bad commit
commit 976b832e9ae199c0a89b0e04e93088da3c829307
Author: Marek Olšák <maraeo@gmail.com>
Date:   Mon Dec 3 17:34:58 2012 +0100

    st/mesa: implement CopyTexSubImage for MSAA framebuffers

    Reviewed-by: Brian Paul <brianp@vmware.com>

    Just use pipe->blit, which can do resolve, flipping, and format conversions.
    The util_blit_pixels codepath is still there for the cases where we have to
    force alpha to 1.

    This also turns on acceleration for copying GL_DEPTH_STENCIL.

:040000 040000 18862accfba92d4eef9871995402af6b8105ed28 e8045e2d2c7e9a1ebd6eb1f22c93b97b9c3e8ce7 M      src
bisect run success
Comment 1 Brian Paul 2013-01-04 16:12:12 UTC 
Vinson, can you retest?  Seems OK here with current Mesa.
Comment 2 Vinson Lee 2013-01-05 02:15:04 UTC 
I still see the "cannot blit stencil, skipping" message.
Comment 3 Andreas Boll 2013-01-30 22:02:00 UTC 
works fine for me
Comment 4 Roland Scheidegger 2014-08-11 18:19:33 UTC 
Current piglit glean does no longer include this test, but the tests replacing it seem to work just fine.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.